Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate scheduler predicate and priority factory registration and associated types #86614

Merged
merged 1 commit into from Dec 26, 2019

Conversation

@ahg-g
Copy link
Member

ahg-g commented Dec 25, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes predicate and priority factory registration, specifically:

  1. Removes all predicate registration in register_predicates.go
  2. Removes all priority registration in register_priorities.go
  3. Removes the types: FitPredicateFactory, PriorityFunctionFactory, PriorityConfigFactory

All predicates and priorities are now statically specified in a couple of maps, those maps will be removed in a followup PR and replaced with direct access to the ConfigProducerRegistry

Note that all removed unit tests have equivalent ones in other places.

Which issue(s) this PR fixes:
Part of #86162

Does this PR introduce a user-facing change?:

NONE

/cc @draveness

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahg-g ahg-g force-pushed the ahg-g:ahg1-default2 branch from 67b9788 to f2d3e03 Dec 25, 2019
@ahg-g ahg-g force-pushed the ahg-g:ahg1-default2 branch 4 times, most recently from 99bcb91 to 09afe44 Dec 25, 2019
mandatoryFitPredicates = sets.NewString()
priorityFunctionMap = make(map[string]PriorityConfigFactory)
algorithmProviderMap = make(map[string]AlgorithmProviderConfig)
// predicate keys supported for backward compatibility with v1.Policy.

This comment has been minimized.

Copy link
@ahg-g

ahg-g Dec 25, 2019

Author Member

NOTE: the following maps replace the explicit registration in the register_predicates.go and register_priorities.go. This is temporary, a follow up PR will remove those and directly use ConfigProducerRegistry defined in framework/plugins

@ahg-g ahg-g changed the title WIP: Deprecate scheduler predicate and priority factory registration Deprecate scheduler predicate and priority factory registration and associated types Dec 25, 2019
@ahg-g ahg-g force-pushed the ahg-g:ahg1-default2 branch 4 times, most recently from 22dce8a to d95791a Dec 25, 2019
@ahg-g ahg-g force-pushed the ahg-g:ahg1-default2 branch from d95791a to 2b3df35 Dec 26, 2019
@ahg-g

This comment has been minimized.

Copy link
Member Author

ahg-g commented Dec 26, 2019

/retest

Copy link
Member

draveness left a comment

/lgtm

Generally looks good, thanks

@zouyee
zouyee approved these changes Dec 26, 2019
@zouyee

This comment has been minimized.

Copy link
Member

zouyee commented Dec 26, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 26, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 04d71d8 into kubernetes:master Dec 26, 2019
16 checks passed
16 checks passed
cla/linuxfoundation ahg-g authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 26, 2019
@ahg-g ahg-g deleted the ahg-g:ahg1-default2 branch Jan 10, 2020
@hectorj2f

This comment has been minimized.

Copy link

hectorj2f commented Jan 24, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.