Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(scheduling): implement azure, cinder, ebs and gce as filter plugin #86662
We could remove the
1 similar comment
ahg-g left a comment
looking at it again, I am not sure why the individual files of each provider was combined into one, it would have been more readable if they were separated (and add a file for the common code), but since you already combined them, I am not going to ask you to revert the change.
Thanks, I combined them because all of the codes in the
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing