Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert reflector changes in 1.17 from PR #83520 to fix #86483 #86823

Closed
wants to merge 98 commits into from

Conversation

@jpbetz
Copy link
Contributor

jpbetz commented Jan 3, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:

#83520 caused a regression in v1.17.0. Reflector relists are causing master rolling upgrade to fail for large clusters due to excessive list calls to etcd. See #86483.

Per #86430 (comment), we're reverting the reflector changes of #83520 in 1.17.

This will be tested manually before merging.

Which issue(s) this PR fixes:

Fixes #86483

Special notes for your reviewer:

This rolls back only the reflector changes. The server side changes were already tested for backward compatibility with old reflectors and are safe.

The pager change is left in place since they are unrelated to the regression. Note that #85272 is related and should be considered when reviewing.

Does this PR introduce a user-facing change?:

Fix v1.17.0 regression in reflector relist causing master rolling upgrade to fail for large clusters due to excessive list calls to etcd

/cc @wojtek-t @liggitt @smarterclayton

/sig api-machinery

Anago GCB and others added 30 commits Oct 29, 2019
…ing CHANGELOG-1.16.md
…ing CHANGELOG-1.11.md CHANGELOG-1.14.md CHANGELOG-1.15.md CHANGELOG-1.16.md
This reverts commit 1ca0ffe.

kube-proxy is not recreating the rules associated to the
KUBE-MARK-DROP chain, that is created by the kubelet.

Is preferrable avoid the dependency between the kubelet and
kube-proxy and that each of them handle their own rules.
…upstream-release-1.17

Automated cherry pick of #85527: Revert "kube-proxy: check KUBE-MARK-DROP"
…0-upstream-release-1.17

Automated cherry pick of #85500: Set node cidr mask size ipv4/ipv6 config
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 3, 2020

@jpbetz: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 3, 2020

@jpbetz: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 3, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpbetz
To complete the pull request process, please assign lavalamp
You can assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpbetz

This comment has been minimized.

Copy link
Contributor Author

jpbetz commented Jan 3, 2020

Fat fingered the open PR button, but this is to master and needs to be to 1.17. Ignore this.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 3, 2020

@jpbetz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 5e071c1 link /test pull-kubernetes-cross
pull-kubernetes-e2e-gce-100-performance 5e071c1 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-e2e-gce-storage-slow 5e071c1 link /test pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-e2e-gce-storage-snapshot 5e071c1 link /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-gce-iscsi 5e071c1 link /test pull-kubernetes-e2e-gce-iscsi
pull-kubernetes-node-e2e 5e071c1 link /test pull-kubernetes-node-e2e
pull-kubernetes-bazel-build 5e071c1 link /test pull-kubernetes-bazel-build
pull-kubernetes-bazel-test 5e071c1 link /test pull-kubernetes-bazel-test
pull-kubernetes-e2e-kind 5e071c1 link /test pull-kubernetes-e2e-kind
pull-kubernetes-conformance-kind-ipv6-parallel 5e071c1 link /test pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-e2e-gce-csi-serial 5e071c1 link /test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-e2e-gce-device-plugin-gpu 5e071c1 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-kubemark-e2e-gce-big 5e071c1 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-dependencies 5e071c1 link /test pull-kubernetes-dependencies
pull-kubernetes-e2e-gci-gce-autoscaling 5e071c1 link /test pull-kubernetes-e2e-gci-gce-autoscaling
pull-kubernetes-e2e-gce-iscsi-serial 5e071c1 link /test pull-kubernetes-e2e-gce-iscsi-serial
pull-kubernetes-e2e-gce 5e071c1 link /test pull-kubernetes-e2e-gce
pull-kubernetes-typecheck 5e071c1 link /test pull-kubernetes-typecheck
pull-kubernetes-integration 5e071c1 link /test pull-kubernetes-integration
pull-kubernetes-verify 5e071c1 link /test pull-kubernetes-verify
pull-kubernetes-node-e2e-containerd 5e071c1 link /test pull-kubernetes-node-e2e-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.