Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update vendored dependency hcsshim to v0.8.7 #86958

Closed
wants to merge 1 commit into from

Conversation

@dims
Copy link
Member

dims commented Jan 8, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
we are using a commit SHA for hcsshim, let's switch over to a release tag

previously filed and closed in #86949, not sure why

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
It has been a long time since the last version update, some bugs were fixed in the middle, and a new version was finally released recently
https://github.com/microsoft/hcsshim/releases/tag/v0.8.7 ( note from @wawa0210 )

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 8, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, cheftako and kubernetes/dep-approvers Jan 8, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 8, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dims
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 8, 2020

/sig node
/priority important-soon

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 8, 2020

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 8, 2020

@dims: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-dependencies 96b1c7f link /test pull-kubernetes-dependencies
pull-kubernetes-node-e2e-containerd 96b1c7f link /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-integration 96b1c7f link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wawa0210

This comment has been minimized.

Copy link
Contributor

wawa0210 commented Jan 8, 2020

What confuses me a lot is that many dependencies of the microsoft/hcsshim repository and many dependencies of kubernetes are inconsistent versions, so I closed my pr before

@wawa0210

This comment has been minimized.

Copy link
Contributor

wawa0210 commented Jan 8, 2020

@dims dims changed the title Update vendored dependency hcsshim to v0.8.7 [WIP] Update vendored dependency hcsshim to v0.8.7 Jan 8, 2020
@dims dims mentioned this pull request Jan 8, 2020
@dims dims closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.