Remove kubectl run generators#87077
Conversation
|
/hold |
0d480d2 to
caee7ab
Compare
|
/sig architecture |
test/e2e/kubectl/kubectl.go
Outdated
There was a problem hiding this comment.
I'm surprised we had a conformance test using deprecated function... that shouldn't really have happened
There was a problem hiding this comment.
yeah, my bad I didn't catch it earlier 😞
dbc8c0a to
e1da66b
Compare
|
/retest |
|
Does this need an issue to remove / revise documentation about generators from the website? |
|
Thinking about this, any website page that recommends using |
Yes, docs pr will follow. |
|
Can we revert this PR ? We can raise this back once I'm done with the exam. |
|
To be clear, the deprecation occurred in #68132 based on SIG CLI's consensus-based decision making. |
|
#91113 should solve the issue @alexellis hope this helps your case 😺 |
|
Nice to have port back, what about the other key flags? |
|
To suggest an enhancement for |
I was taking some Qwiklabs labs, some of kubertes lab rely on For the workaround, you can just use the old version where |
Remove kubectl run generators Kubernetes-commit: dba8d60
|
kubectl run for deployments is being missed, can we get the features back in create please, this will make a lot of difference |
|
@tm1810 you can check kubernetes/kubectl#898 |
removed in PR 87077: kubernetes/kubernetes#87077
What type of PR is this?
/kind api-change
/kind cleanup
/kind deprecation
/priority backlog
/sig cli
What this PR does / why we need it:
Over a year ago we've deprecated all the generators from under
kubectl runcommand except for the one responsible for generating a pod (see #68132).This PR removes all the generators and deprecates all the flags towards the goal to make
kubectl runsimpler.Special notes for your reviewer:
/assign @liggitt @seans3 @pwittrock
Does this PR introduce a user-facing change?:
/cc @kubernetes/sig-cli-api-reviews @kubernetes/sig-cli-pr-reviews