Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubectl run generators #87077

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jan 10, 2020

What type of PR is this?
/kind api-change
/kind cleanup
/kind deprecation
/priority backlog
/sig cli

What this PR does / why we need it:
Over a year ago we've deprecated all the generators from under kubectl run command except for the one responsible for generating a pod (see #68132).
This PR removes all the generators and deprecates all the flags towards the goal to make kubectl run simpler.

Special notes for your reviewer:
/assign @liggitt @seans3 @pwittrock

Does this PR introduce a user-facing change?:

Remove all the generators from kubectl run. It will now only create pods. Additionally, deprecates all the flags that are not relevant anymore.

/cc @kubernetes/sig-cli-api-reviews @kubernetes/sig-cli-pr-reviews

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/backlog Higher priority than priority/awaiting-more-evidence. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 10, 2020
@soltysh
Copy link
Contributor Author

soltysh commented Jan 10, 2020

/hold
for visibility

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2020
@soltysh
Copy link
Contributor Author

soltysh commented Jan 10, 2020

/sig architecture
@kubernetes/sig-architecture-api-reviews since this is dropping a few of conformance tests

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2020
Testname: Kubectl, run deployment
Description: Command ‘kubectl run’ MUST create a deployment, with --generator=deployment, when a image name is specified in the run command. After the run command there SHOULD be a deployment that should exist with one container running the specified image. Also there SHOULD be a Pod that is controlled by this deployment, with a container running the specified image.
*/
framework.ConformanceIt("should create a deployment from an image ", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised we had a conformance test using deprecated function... that shouldn't really have happened

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, my bad I didn't catch it earlier 😞

@soltysh soltysh force-pushed the remove_run_generators branch 2 times, most recently from dbc8c0a to e1da66b Compare January 10, 2020 17:33
@soltysh
Copy link
Contributor Author

soltysh commented Jan 10, 2020

/retest

@sftim
Copy link
Contributor

sftim commented Jan 11, 2020

Does this need an issue to remove / revise documentation about generators from the website?
(there might be one already)

@sftim
Copy link
Contributor

sftim commented Jan 11, 2020

Thinking about this, any website page that recommends using kubectl run will need to change. There might be some left.

@soltysh
Copy link
Contributor Author

soltysh commented Jan 14, 2020

Does this need an issue to remove / revise documentation about generators from the website?
(there might be one already)

Yes, docs pr will follow.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2020
@NinjaPanda91
Copy link

Can we revert this PR ?
--port, --replicas flags and a bunch of flags are missing and I'm studying for CKA exam and i just found out it uses 1.18.

We can raise this back once I'm done with the exam.

@sftim
Copy link
Contributor

sftim commented May 13, 2020

To be clear, the deprecation occurred in #68132 based on SIG CLI's consensus-based decision making.
If you'd like to enhance kubectl create, or to suggest enhancements, I feel that those suggestions are much more likely to be accepted.

@soltysh
Copy link
Contributor Author

soltysh commented May 14, 2020

#91113 should solve the issue @alexellis hope this helps your case 😺

@alexellis
Copy link

Nice to have port back, what about the other key flags?

@sftim
Copy link
Contributor

sftim commented May 14, 2020

To suggest an enhancement for kubectl, you can visit https://github.com/kubernetes/kubectl/issues/new (and I hope that people will make these suggestions)

@supirman
Copy link

Can we revert this PR ?
--port, --replicas flags and a bunch of flags are missing and I'm studying for CKA exam and i just found out it uses 1.18.

We can raise this back once I'm done with the exam.

I was taking some Qwiklabs labs, some of kubertes lab rely on kubectl run. It seem that kubectl in Google Cloud Shell got update recently and the lab not updated to this issue.

For the workaround, you can just use the old version where kubectl run still working in old ways.

wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
Remove kubectl run generators

Kubernetes-commit: dba8d60
@tm1810
Copy link

tm1810 commented Aug 29, 2020

kubectl run for deployments is being missed, can we get the features back in create please, this will make a lot of difference

@armujahid
Copy link

@tm1810 you can check kubernetes/kubectl#898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet