Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
do not evict high priority pods when diskPressure in k8s 1.15 #87144
What type of PR is this?
What this PR does / why we need it:
This PR adds check for mirror pod for criticality.
Which issue(s) this PR fixes:
From the listen godoc: For TCP networks, if the host in the address parameter is empty or a literal unspecified IP address, Listen listens on all available unicast and anycast IP addresses of the local system. Since the BindNetwork options is "tcp" by default, using an unspecified address doesn't bind the listener to the IP family.
The `FakeDockerClient` had a number of methods defined on it which were not being called anywhere. The majority were of the form `Assert...`. In the spirit of removing dead code, remove the methods which aren't being called.
This commit is part of a larger effort to clean up references to `rkt` in the kubelet. Previously, this comment hard-coded which integrations required the cadvisor stats provider. The comment has grown stale (i.e. referenced rkt and did not reference cri-o). Update the comment to instead point to the code which determines which integrations need the cadvisor stats provider.
Part of efforts to clean up mentions of rkt in kubelet. rkt was removed entirely in 1.11, in favor of using `rktlet` and CRI instead. It should no longer be listed at all as a runtime.
- don't proceed when a file creation has been failed - handle a possible error from WriteString()
mattjmcnaughton left a comment
Hi @andy-wolf168 !
It looks like this cherry-pick got created in a bit of an unorthodox way - could I trouble you to close this diff and recreate it following the instructions here? https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md
Doing so will make it easier for reviewers to determine the exact changes you're proposing cherry-picking. Thanks! Let me know if you have any questions :)