Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not evict high priority pods when diskPressure in k8s 1.15 #87144

wants to merge 7,985 commits into
base: release-1.15


Copy link

andy-wolf168 commented Jan 13, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
As #83317 reported, static pod would be evicted when diskPressure arises.

This PR adds check for mirror pod for criticality.

Which issue(s) this PR fixes:
Fixes #83317

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

aojea and others added 30 commits Jan 4, 2020
From the listen godoc:

For TCP networks, if the host in the address parameter is empty or a
literal unspecified IP address, Listen listens on all available unicast
and anycast IP addresses of the local system.

Since the BindNetwork options is "tcp" by default, using an unspecified
address doesn't bind the listener to the IP family.
fix: correct the mentioned endpointslice manage label name.
Break volumebinding Filter plugins dependency on predicates package
Break DS controller dependency on scheduler predicates and predicate errors
clarify apiserver bind-address flag usage

remove unused code and use framework
The `FakeDockerClient` had a number of methods defined on it which were
not being called anywhere. The majority were of the form `Assert...`.

In the spirit of removing dead code, remove the methods which aren't
being called.
This commit is part of a larger effort to clean up references to `rkt`
in the kubelet.

Previously, this comment hard-coded which integrations required
the cadvisor stats provider. The comment has grown stale
(i.e. referenced rkt and did not reference cri-o).

Update the comment to instead point to the code which determines which
integrations need the cadvisor stats provider.
Return when removePod failed
Part of efforts to clean up mentions of rkt in kubelet.

rkt was removed entirely in 1.11, in favor of using `rktlet` and CRI
instead. It should no longer be listed at all as a runtime.
Cleanup deprecated scheduler functions/files
Perform dead storage removal linearly

Break volumerestrictions Filter plugins dependency on predicates package
Log mvcc revision compaction as warning

wrap bootstrap-creation-flow w/ wait.PollUtil

go wait
Remove ineffective calls in toUnstructured
- don't proceed when a file creation has been failed
- handle a possible error from WriteString()

Fix local cluster do not work with non-intree external cloud provider issue
Add klueska as an approver in pkg/kubelet/cm/OWNERS
Copy link

mattjmcnaughton left a comment

Hi @andy-wolf168 !

It looks like this cherry-pick got created in a bit of an unorthodox way - could I trouble you to close this diff and recreate it following the instructions here?

Doing so will make it easier for reviewers to determine the exact changes you're proposing cherry-picking. Thanks! Let me know if you have any questions :)


This comment has been minimized.

Copy link

neolit123 commented Jan 13, 2020

/remove-area kubeadm


This comment has been minimized.

Copy link

justaugustus commented Jan 18, 2020

/hold all cherry picks are held until resolution of #86182 (tentative next week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.