Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set test image cloudbuild directory #87162

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@BenTheElder
Copy link
Member

BenTheElder commented Jan 13, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change

/kind bug

/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Sets the test/images cloudbuild to point to the correct directory for image auto-push-ing

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: This will not run until post-submit.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE
@BenTheElder

This comment has been minimized.

Copy link
Member Author

BenTheElder commented Jan 13, 2020

@k8s-ci-robot k8s-ci-robot requested review from Katharine and liggitt Jan 13, 2020
@BenTheElder

This comment has been minimized.

Copy link
Member Author

BenTheElder commented Jan 13, 2020

/priority important-soon
/sig release

@BenTheElder

This comment has been minimized.

Copy link
Member Author

BenTheElder commented Jan 13, 2020

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 13, 2020

Awesome! Nice to see that we're heading down this path!

ref other discussions on image building in k/k: #80909, #71719, kubernetes/release#964
cc: @hoegaarden @cpanato @ameukam

/lgtm
/approve
/area release-eng

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 13, 2020

/retest

@dims

This comment has been minimized.

Copy link
Member

dims commented Jan 13, 2020

/lgtm

Copy link
Member

cpanato left a comment

/lgtm

@claudiubelu

This comment has been minimized.

Copy link
Contributor

claudiubelu commented Jan 14, 2020

/lgtm
/test pull-kubernetes-e2e-gce

We're also going to need this: #87188

@claudiubelu

This comment has been minimized.

Copy link
Contributor

claudiubelu commented Jan 14, 2020

/test pull-kubernetes-e2e-gce

1 similar comment
@claudiubelu

This comment has been minimized.

Copy link
Contributor

claudiubelu commented Jan 14, 2020

/test pull-kubernetes-e2e-gce

@BenTheElder

This comment has been minimized.

Copy link
Member Author

BenTheElder commented Jan 14, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit b2c61fa into kubernetes:master Jan 15, 2020
17 checks passed
17 checks passed
cla/linuxfoundation BenTheElder authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Release Engineering automation moved this from In progress to Done (1.18) Jan 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.