Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use v1 subjectaccessreview API in controller-manager CSR approver #87164
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: liggitt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
1 similar comment
2 similar comments
On Mon, Jan 13, 2020, 19:20 Kubernetes Prow Robot ***@***.***> wrote: @liggitt <https://github.com/liggitt>: The following test *failed*, say /retest to rerun all failed tests: Test name Commit Details Rerun command pull-kubernetes-e2e-gce 054e384 <054e384> link <https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/87164/pull-kubernetes-e2e-gce/1216908911454457857/> /test pull-kubernetes-e2e-gce Full PR test history <https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=87164>. Your PR dashboard <https://gubernator.k8s.io/pr/liggitt>. Please help us cut down on flakes by linking to <https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#87164?email_source=notifications&email_token=AAHADK5FIZ4LVYQ2IPYKYVTQ5UVOFA5CNFSM4KGIVWE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI3EAWA#issuecomment-573980760>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHADK7LDVVGVHIX4OLOD63Q5UVOFANCNFSM4KGIVWEQ> .