Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1 subjectaccessreview API in controller-manager CSR approver #87164

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@liggitt
Copy link
Member

liggitt commented Jan 13, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Part of conformance without beta efforts, ensures v1 APIs are used wherever possible.

Does this PR introduce a user-facing change?:

NONE

/sig auth
/cc @BenTheElder

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 13, 2020

/cc @enj

@k8s-ci-robot k8s-ci-robot requested a review from enj Jan 13, 2020
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 13, 2020

/priority important-soon

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 13, 2020

/retest

1 similar comment
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 13, 2020

/retest

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Jan 13, 2020

we're aware of a potential issue with blockfs tests that seem to be causing some flakes, I'll be working on that soon.

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Jan 13, 2020

/lgtm
thanks!

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 13, 2020

/retest

2 similar comments
@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Jan 14, 2020

/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 14, 2020

/retest

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Jan 14, 2020

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Jan 14, 2020

/retest

@enj

This comment has been minimized.

Copy link
Member

enj commented Jan 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 9173a5f into kubernetes:master Jan 15, 2020
16 checks passed
16 checks passed
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 15, 2020
@liggitt liggitt deleted the liggitt:sar-approver-v1 branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.