Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Snapshot to internal/cache #87165

Merged
merged 2 commits into from Jan 18, 2020

Conversation

@alculquicondor
Copy link
Member

alculquicondor commented Jan 13, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The snapshot implementation is highly linked to the Cache. Other users only need the SharedListers interface.

Which issue(s) this PR fixes:

Fixes #87033

Does this PR introduce a user-facing change?:

NONE
@alculquicondor

This comment has been minimized.

Copy link
Member Author

alculquicondor commented Jan 13, 2020

/priority important-longterm

@k8s-ci-robot k8s-ci-robot requested review from k82cn and wgliang Jan 13, 2020
@alculquicondor alculquicondor force-pushed the alculquicondor:cleanup/mv_snapshot_2 branch 4 times, most recently from 39d9830 to 5e909d3 Jan 13, 2020
@alculquicondor

This comment has been minimized.

Copy link
Member Author

alculquicondor commented Jan 14, 2020

/retest

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Jan 16, 2020

/cc

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g Jan 16, 2020
@alculquicondor

This comment has been minimized.

Copy link
Member Author

alculquicondor commented Jan 16, 2020

This is already ready for review :)

/assign @ahg-g

pkg/scheduler/listers/listers.go Outdated Show resolved Hide resolved
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@alculquicondor alculquicondor force-pushed the alculquicondor:cleanup/mv_snapshot_2 branch from 5e909d3 to 50d8b34 Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added size/L and removed size/XL labels Jan 17, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alculquicondor alculquicondor force-pushed the alculquicondor:cleanup/mv_snapshot_2 branch from 50d8b34 to ee900af Jan 17, 2020
@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Jan 17, 2020

Thanks, please squash.

Signed-off-by: Aldo Culquicondor <acondor@google.com>
@alculquicondor alculquicondor force-pushed the alculquicondor:cleanup/mv_snapshot_2 branch from ee900af to f53d7e5 Jan 17, 2020
@alculquicondor

This comment has been minimized.

Copy link
Member Author

alculquicondor commented Jan 17, 2020

Done. But I'm keeping 2 logical commits.

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Jan 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 17, 2020
@alculquicondor

This comment has been minimized.

Copy link
Member Author

alculquicondor commented Jan 17, 2020

/hold for a rebase

@alculquicondor

This comment has been minimized.

Copy link
Member Author

alculquicondor commented Jan 17, 2020

/hold cancel

Sorry, I got confused with my other PR :)

@alculquicondor

This comment has been minimized.

Copy link
Member Author

alculquicondor commented Jan 17, 2020

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 18, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 3538320 into kubernetes:master Jan 18, 2020
16 of 17 checks passed
16 of 17 checks passed
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation alculquicondor authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.