Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use e2eskipper package in e2e/scheduling and e2e/servicecatalog #87169

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@s-ito-ts
Copy link
Contributor

s-ito-ts commented Jan 14, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Use e2eskipper package in e2e/scheduling and e2e/servicecatalog directory.

Which issue(s) this PR fixes:
Ref #87047

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Jan 14, 2020

/assign @oomichi
/lgtm

@s-ito-ts

This comment has been minimized.

Copy link
Contributor Author

s-ito-ts commented Jan 14, 2020

/test pull-kubernetes-e2e-kind-ipv6
/test pull-kubernetes-integration
/test pull-kubernetes-e2e-gce

@s-ito-ts

This comment has been minimized.

Copy link
Contributor Author

s-ito-ts commented Jan 14, 2020

/test pull-kubernetes-e2e-gce

Copy link
Member

SataQiu left a comment

Thanks @s-ito-ts
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-ito-ts, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oomichi oomichi mentioned this pull request Jan 14, 2020
13 of 15 tasks complete
@k8s-ci-robot k8s-ci-robot merged commit de04f52 into kubernetes:master Jan 15, 2020
17 checks passed
17 checks passed
cla/linuxfoundation s-ito-ts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.