Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Typos in GCP auth plugin comments. #87172

Open
wants to merge 1 commit into
base: master
from

Conversation

@dooman87
Copy link

dooman87 commented Jan 14, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug

/kind cleanup

/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This is a small change to docs of the gcp auth plugin fo Golang client.

I was also thinking of adding specific example to use client-go with GCP. It took me some time to find out that I need to Base64 decode
cluster certificate that I got from GCP API. Otherwise I was getting x509: certificate signed by unknown authority error. Do you think such an example would be useful?

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

Welcome @dooman87!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

Hi @dooman87. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from cjcullen and krousey Jan 14, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dooman87
To complete the pull request process, please assign cjcullen
You can assign the PR to them by writing /assign @cjcullen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dooman87

This comment has been minimized.

Copy link
Author

dooman87 commented Jan 14, 2020

/assign @cjcullen

@php-coder

This comment has been minimized.

Copy link
Contributor

php-coder commented Jan 15, 2020

/release-note-none
/ok-to-test

@dooman87

This comment has been minimized.

Copy link
Author

dooman87 commented Jan 15, 2020

/retest

@dooman87

This comment has been minimized.

Copy link
Author

dooman87 commented Jan 15, 2020

@cjcullen @php-coder Not sure why test is failing. I tried to rerun it but it seemed like it failed again. Are tests using the comments that I've changed?

@php-coder

This comment has been minimized.

Copy link
Contributor

php-coder commented Jan 15, 2020

I tried to rerun it but it seemed like it failed again. Are tests using the comments that I've changed?

Unfortunately, tests are flaky and re-running them only once isn't enough :-(

/test pull-kubernetes-e2e-gce

@php-coder

This comment has been minimized.

Copy link
Contributor

php-coder commented Jan 15, 2020

/priority backlog

@dooman87

This comment has been minimized.

Copy link
Author

dooman87 commented Jan 15, 2020

/retest

@php-coder

This comment has been minimized.

Copy link
Contributor

php-coder commented Jan 16, 2020

PTAL @cjcullen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.