Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use e2eskipper package in test/e2e/autoscaling #87173

Merged
merged 1 commit into from Jan 16, 2020

Conversation

@YuikoTakada
Copy link
Contributor

YuikoTakada commented Jan 14, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR use e2eskipper package instead of using func Skip* in kubernetes/test/e2e/framework/skip.go

Which issue(s) this PR fixes:
Ref: #87047

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

Hi @YuikoTakada. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k-toyoda-pi

This comment has been minimized.

Copy link
Contributor

k-toyoda-pi commented Jan 14, 2020

/ok-to-test

@YuikoTakada YuikoTakada force-pushed the YuikoTakada:move_skip_e2e_asg branch from e4a3a31 to c402a4b Jan 14, 2020
@oomichi oomichi mentioned this pull request Jan 14, 2020
13 of 15 tasks complete
@YuikoTakada YuikoTakada changed the title WIP: use e2eskipper package in test/e2e/autoscaling Use e2eskipper package in test/e2e/autoscaling Jan 16, 2020
@YuikoTakada

This comment has been minimized.

Copy link
Contributor Author

YuikoTakada commented Jan 16, 2020

/assign @SataQiu

Copy link
Member

SataQiu left a comment

/lgtm
/assign @oomichi

@SataQiu

This comment has been minimized.

Copy link
Member

SataQiu commented Jan 16, 2020

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-gce

@oomichi

This comment has been minimized.

Copy link
Member

oomichi commented Jan 16, 2020

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, YuikoTakada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9ae36ba into kubernetes:master Jan 16, 2020
17 checks passed
17 checks passed
cla/linuxfoundation YuikoTakada authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.