Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level to 3 when --random-fully is not supported in ipvs mode #87176

Open
wants to merge 1 commit into
base: master
from

Conversation

@libnux
Copy link
Contributor

libnux commented Jan 14, 2020

My last RR #86583, failed to change code related to ipvs mode. This PR fixes this.

/release-note-none

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

@libnux: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

Hi @libnux. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@libnux

This comment has been minimized.

Copy link
Contributor Author

libnux commented Jan 14, 2020

/sig network
/priority backlog

@libnux

This comment has been minimized.

Copy link
Contributor Author

libnux commented Jan 14, 2020

/kind cleanup

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: libnux
To complete the pull request process, please assign brendandburns, vishh
You can assign the PR to them by writing /assign @brendandburns @vishh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@libnux

This comment has been minimized.

Copy link
Contributor Author

libnux commented Jan 14, 2020

@danwinship

This comment has been minimized.

Copy link
Contributor

danwinship commented Jan 14, 2020

I'm not sure any of the logging around --masquerade-fully is really necessary. If people want to check if it was used they can just run iptables-save and see...

Copy link
Contributor

mattjmcnaughton left a comment

/lgtm

Makes sense to me that we'd want consistency for this logging level, and #86583 approved this change for other scenarios.

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 14, 2020
@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

mattjmcnaughton commented Jan 14, 2020

/ok-to-test

@libnux

This comment has been minimized.

Copy link
Contributor Author

libnux commented Jan 15, 2020

/retest

@libnux libnux requested a review from mattjmcnaughton Jan 16, 2020
@libnux

This comment has been minimized.

Copy link
Contributor Author

libnux commented Jan 16, 2020

@mattjmcnaughton, could you please help reivew and approve? Thanks

Copy link
Contributor

mattjmcnaughton left a comment

/lgtm

Still looks good to me! You will need an approver to approve in order for it to be merged. I added two below:

/assign @brendandburns @yujuhong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.