Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static check failures in test/e2e/instrumentation/logging/st… #87178

Open
wants to merge 1 commit into
base: master
from

Conversation

@YuikoTakada
Copy link
Contributor

YuikoTakada commented Jan 14, 2020

What type of PR is this?
/kind bug
/kind cleanup

What this PR does / why we need it:
This PR fixes static check failures in test/e2e/instrumentation/logging/stackdriver

Which issue(s) this PR fixes:
Ref: #81657

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

Hi @YuikoTakada. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YuikoTakada
To complete the pull request process, please assign bentheelder
You can assign the PR to them by writing /assign @bentheelder in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oomichi

This comment has been minimized.

Copy link
Member

oomichi commented Jan 14, 2020

/ok-to-test

@YuikoTakada YuikoTakada force-pushed the YuikoTakada:fix_81657_1 branch from 2171e72 to 1cccd37 Jan 14, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 15, 2020

@YuikoTakada: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 1cccd37 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harlowja

This comment has been minimized.

Copy link

harlowja commented Jan 15, 2020

/meow

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 15, 2020

@harlowja: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YuikoTakada YuikoTakada changed the title WIP: Fix static check failures in test/e2e/instrumentation/logging/st… Fix static check failures in test/e2e/instrumentation/logging/st… Jan 16, 2020
@YuikoTakada

This comment has been minimized.

Copy link
Contributor Author

YuikoTakada commented Jan 16, 2020

/assign @SataQiu

@@ -84,8 +85,8 @@ type sdLogProvider struct {

func newSdLogProvider(f *framework.Framework, scope logProviderScope) (*sdLogProvider, error) {
ctx := context.Background()
hc, err := google.DefaultClient(ctx, sd.CloudPlatformScope)
sdService, err := sd.New(hc)
hc, _ := google.DefaultClient(ctx, sd.CloudPlatformScope)

This comment has been minimized.

Copy link
@SataQiu

SataQiu Jan 16, 2020

Member

We'd better deal with this error.

Suggested change
hc, _ := google.DefaultClient(ctx, sd.CloudPlatformScope)
hc, err := google.DefaultClient(ctx, sd.CloudPlatformScope)
framework.ExpectNoError(err)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.