Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment in hack/update-*.sh #87181

Merged
merged 1 commit into from Jan 16, 2020

Conversation

@tanjunchen
Copy link
Member

tanjunchen commented Jan 14, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

kubernetes/hack/update-all.sh
kubernetes/hack/update-bazel.sh
kubernetes/hack/update-codegen.sh
kubernetes/hack/update-generated-api-compatibility-data.sh
kubernetes/hack/update-generated-device-plugin-dockerized.sh
kubernetes/hack/update-generated-device-plugin.sh
kubernetes/hack/update-generated-docs.sh
kubernetes/hack/update-generated-kms-dockerized.sh
kubernetes/hack/update-generated-kms.sh
kubernetes/hack/update-generated-kubelet-plugin-registration-dockerized.sh
kubernetes/hack/update-generated-kubelet-plugin-registration.sh
kubernetes/hack/update-generated-pod-resources-dockerized.sh
kubernetes/hack/update-generated-pod-resources.sh
kubernetes/hack/update-generated-protobuf-dockerized.sh
kubernetes/hack/update-generated-protobuf.sh
kubernetes/hack/update-generated-runtime-dockerized.sh
kubernetes/hack/update-generated-runtime.sh
kubernetes/hack/update-generated-swagger-docs.sh
kubernetes/hack/update-gofmt.sh
kubernetes/hack/update-import-aliases.sh
kubernetes/hack/update-openapi-spec.sh
kubernetes/hack/update-translations.sh
kubernetes/hack/update-vendor-licenses.sh
kubernetes/hack/update-vendor.sh
kubernetes/hack/update-workspace-mirror.sh

update the comment for them

Which issue(s) this PR fixes:

ref:#86597

Special notes for your reviewer:
/cc @fejta

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

@tanjunchen: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

2 similar comments
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

@tanjunchen: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

@tanjunchen: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

@tanjunchen: The label(s) kind/document cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind cleanup
/kind document

What this PR does / why we need it:

kubernetes/hack/update-all.sh
kubernetes/hack/update-bazel.sh
kubernetes/hack/update-codegen.sh
kubernetes/hack/update-generated-api-compatibility-data.sh
kubernetes/hack/update-generated-device-plugin-dockerized.sh
kubernetes/hack/update-generated-device-plugin.sh
kubernetes/hack/update-generated-docs.sh
kubernetes/hack/update-generated-kms-dockerized.sh
kubernetes/hack/update-generated-kms.sh
kubernetes/hack/update-generated-kubelet-plugin-registration-dockerized.sh
kubernetes/hack/update-generated-kubelet-plugin-registration.sh
kubernetes/hack/update-generated-pod-resources-dockerized.sh
kubernetes/hack/update-generated-pod-resources.sh
kubernetes/hack/update-generated-protobuf-dockerized.sh
kubernetes/hack/update-generated-protobuf.sh
kubernetes/hack/update-generated-runtime-dockerized.sh
kubernetes/hack/update-generated-runtime.sh
kubernetes/hack/update-generated-swagger-docs.sh
kubernetes/hack/update-gofmt.sh
kubernetes/hack/update-import-aliases.sh
kubernetes/hack/update-openapi-spec.sh
kubernetes/hack/update-translations.sh
kubernetes/hack/update-vendor-licenses.sh
kubernetes/hack/update-vendor.sh
kubernetes/hack/update-workspace-mirror.sh

update the comment for them

Which issue(s) this PR fixes:

ref:#86597

Special notes for your reviewer:
/cc @fejta

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 14, 2020

/remove deprcation

Copy link
Contributor

fejta left a comment

/lgtm
/approve

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 15, 2020

/retest
/kind cleanup
/priority backlog

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 15, 2020

/remove-kind deprecation
/release-note-none

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 15, 2020

@tanjunchen: Those labels are not set on the issue: kind/deprecation

In response to this:

/remove-kind deprecation
/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 15, 2020

/release-note-none

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 15, 2020

/test pull-kubernetes-e2e-gce

1 similar comment
@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 15, 2020

/test pull-kubernetes-e2e-gce

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 15, 2020

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing and removed needs-sig labels Jan 15, 2020
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 15, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Copy link
Contributor

fejta left a comment

/lgtm
/approve

@@ -13,6 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# This script updates the bazel compilation files once. We should run
# `hack/update-bazel.sh` once we modify the reference package of the Go file.
# Usage: `hack/update-bazel.sh`.

This comment has been minimized.

Copy link
@fejta

fejta Jan 15, 2020

Contributor

These seem pretty pointless

This comment has been minimized.

Copy link
@tanjunchen

tanjunchen Jan 16, 2020

Author Member

done . i will update it

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 15, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 16, 2020

/hold

@tanjunchen tanjunchen force-pushed the tanjunchen:add-comment-hack-update branch from 5a68584 to b2f76cc Jan 16, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 16, 2020
@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 16, 2020

/hold cancel

@yuxiaobo96

This comment has been minimized.

Copy link
Member

yuxiaobo96 commented Jan 16, 2020

/lgtm
good job !

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 16, 2020

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit 47475c6 into kubernetes:master Jan 16, 2020
16 checks passed
16 checks passed
cla/linuxfoundation tanjunchen authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 16, 2020
@tanjunchen tanjunchen deleted the tanjunchen:add-comment-hack-update branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.