New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add comment in hack/update-*.sh #87181
add comment in hack/update-*.sh #87181
Conversation
@tanjunchen: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
@tanjunchen: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tanjunchen: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tanjunchen: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove deprcation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest |
/remove-kind deprecation |
@tanjunchen: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/release-note-none |
/test pull-kubernetes-e2e-gce |
1 similar comment
/test pull-kubernetes-e2e-gce |
/sig testing |
/retest Review the full test history for this PR. Silence the bot with an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
hack/update-bazel.sh
Outdated
@@ -13,6 +13,10 @@ | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
|
|||
# This script updates the bazel compilation files once. We should run | |||
# `hack/update-bazel.sh` once we modify the reference package of the Go file. | |||
# Usage: `hack/update-bazel.sh`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem pretty pointless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done . i will update it
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, tanjunchen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
/hold |
/hold cancel |
/lgtm |
/test pull-kubernetes-e2e-kind-ipv6 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
kubernetes/hack/update-all.sh
kubernetes/hack/update-bazel.sh
kubernetes/hack/update-codegen.sh
kubernetes/hack/update-generated-api-compatibility-data.sh
kubernetes/hack/update-generated-device-plugin-dockerized.sh
kubernetes/hack/update-generated-device-plugin.sh
kubernetes/hack/update-generated-docs.sh
kubernetes/hack/update-generated-kms-dockerized.sh
kubernetes/hack/update-generated-kms.sh
kubernetes/hack/update-generated-kubelet-plugin-registration-dockerized.sh
kubernetes/hack/update-generated-kubelet-plugin-registration.sh
kubernetes/hack/update-generated-pod-resources-dockerized.sh
kubernetes/hack/update-generated-pod-resources.sh
kubernetes/hack/update-generated-protobuf-dockerized.sh
kubernetes/hack/update-generated-protobuf.sh
kubernetes/hack/update-generated-runtime-dockerized.sh
kubernetes/hack/update-generated-runtime.sh
kubernetes/hack/update-generated-swagger-docs.sh
kubernetes/hack/update-gofmt.sh
kubernetes/hack/update-import-aliases.sh
kubernetes/hack/update-openapi-spec.sh
kubernetes/hack/update-translations.sh
kubernetes/hack/update-vendor-licenses.sh
kubernetes/hack/update-vendor.sh
kubernetes/hack/update-workspace-mirror.sh
update the comment for them
Which issue(s) this PR fixes:
ref:#86597
Special notes for your reviewer:
/cc @fejta
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: