Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment in hack/update-*.sh #87181

Merged
merged 1 commit into from Jan 16, 2020
Merged

add comment in hack/update-*.sh #87181

merged 1 commit into from Jan 16, 2020

Conversation

tanjunchen
Copy link
Member

@tanjunchen tanjunchen commented Jan 14, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

kubernetes/hack/update-all.sh
kubernetes/hack/update-bazel.sh
kubernetes/hack/update-codegen.sh
kubernetes/hack/update-generated-api-compatibility-data.sh
kubernetes/hack/update-generated-device-plugin-dockerized.sh
kubernetes/hack/update-generated-device-plugin.sh
kubernetes/hack/update-generated-docs.sh
kubernetes/hack/update-generated-kms-dockerized.sh
kubernetes/hack/update-generated-kms.sh
kubernetes/hack/update-generated-kubelet-plugin-registration-dockerized.sh
kubernetes/hack/update-generated-kubelet-plugin-registration.sh
kubernetes/hack/update-generated-pod-resources-dockerized.sh
kubernetes/hack/update-generated-pod-resources.sh
kubernetes/hack/update-generated-protobuf-dockerized.sh
kubernetes/hack/update-generated-protobuf.sh
kubernetes/hack/update-generated-runtime-dockerized.sh
kubernetes/hack/update-generated-runtime.sh
kubernetes/hack/update-generated-swagger-docs.sh
kubernetes/hack/update-gofmt.sh
kubernetes/hack/update-import-aliases.sh
kubernetes/hack/update-openapi-spec.sh
kubernetes/hack/update-translations.sh
kubernetes/hack/update-vendor-licenses.sh
kubernetes/hack/update-vendor.sh
kubernetes/hack/update-workspace-mirror.sh

update the comment for them

Which issue(s) this PR fixes:

ref:#86597

Special notes for your reviewer:
/cc @fejta

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Jan 14, 2020
@k8s-ci-robot
Copy link
Contributor

@tanjunchen: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

2 similar comments
@k8s-ci-robot
Copy link
Contributor

@tanjunchen: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@tanjunchen: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 14, 2020
@k8s-ci-robot
Copy link
Contributor

@tanjunchen: The label(s) kind/document cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind cleanup
/kind document

What this PR does / why we need it:

kubernetes/hack/update-all.sh
kubernetes/hack/update-bazel.sh
kubernetes/hack/update-codegen.sh
kubernetes/hack/update-generated-api-compatibility-data.sh
kubernetes/hack/update-generated-device-plugin-dockerized.sh
kubernetes/hack/update-generated-device-plugin.sh
kubernetes/hack/update-generated-docs.sh
kubernetes/hack/update-generated-kms-dockerized.sh
kubernetes/hack/update-generated-kms.sh
kubernetes/hack/update-generated-kubelet-plugin-registration-dockerized.sh
kubernetes/hack/update-generated-kubelet-plugin-registration.sh
kubernetes/hack/update-generated-pod-resources-dockerized.sh
kubernetes/hack/update-generated-pod-resources.sh
kubernetes/hack/update-generated-protobuf-dockerized.sh
kubernetes/hack/update-generated-protobuf.sh
kubernetes/hack/update-generated-runtime-dockerized.sh
kubernetes/hack/update-generated-runtime.sh
kubernetes/hack/update-generated-swagger-docs.sh
kubernetes/hack/update-gofmt.sh
kubernetes/hack/update-import-aliases.sh
kubernetes/hack/update-openapi-spec.sh
kubernetes/hack/update-translations.sh
kubernetes/hack/update-vendor-licenses.sh
kubernetes/hack/update-vendor.sh
kubernetes/hack/update-workspace-mirror.sh

update the comment for them

Which issue(s) this PR fixes:

ref:#86597

Special notes for your reviewer:
/cc @fejta

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tanjunchen
Copy link
Member Author

/remove deprcation

Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2020
@tanjunchen
Copy link
Member Author

/retest
/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 15, 2020
@tanjunchen
Copy link
Member Author

tanjunchen commented Jan 15, 2020

/remove-kind deprecation
/release-note-none

@k8s-ci-robot k8s-ci-robot removed the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Jan 15, 2020
@k8s-ci-robot
Copy link
Contributor

@tanjunchen: Those labels are not set on the issue: kind/deprecation

In response to this:

/remove-kind deprecation
/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tanjunchen
Copy link
Member Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 15, 2020
@tanjunchen
Copy link
Member Author

/test pull-kubernetes-e2e-gce

1 similar comment
@tanjunchen
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@tanjunchen
Copy link
Member Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 15, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@@ -13,6 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# This script updates the bazel compilation files once. We should run
# `hack/update-bazel.sh` once we modify the reference package of the Go file.
# Usage: `hack/update-bazel.sh`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem pretty pointless

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done . i will update it

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@tanjunchen
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2020
@tanjunchen
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020
@yuxiaobo96
Copy link
Contributor

/lgtm
good job !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2020
@tanjunchen
Copy link
Member Author

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit 47475c6 into kubernetes:master Jan 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 16, 2020
@tanjunchen tanjunchen deleted the add-comment-hack-update branch January 16, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants