Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #82267: kubeadm: Form correct URL for IPv6 in HTTPProxy check #87186

Open

Conversation

@rosti
Copy link
Member

rosti commented Jan 14, 2020

Cherry pick of #82267 on release-1.15.

#82267: kubeadm: Form correct URL for IPv6 in HTTPProxy check

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

@rosti: This cherry pick PR is for a release branch and has not yet been approved by the Patch Release Team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, please ping the kubernetes/patch-release-team in a comment, after it has been approved by the relevant OWNERS.
For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Force correct syntax on host/port in URL of HTTPProxy check
if the host argument is a raw IPv6 address string
@@ -437,9 +437,12 @@ func (hst HTTPProxyCheck) Name() string {
// Check validates http connectivity type, direct or via proxy.
func (hst HTTPProxyCheck) Check() (warnings, errorList []error) {
klog.V(1).Infoln("validating if the connectivity type is via proxy or direct")
u := (&url.URL{Scheme: hst.Proto, Host: hst.Host}).String()
u := &url.URL{Scheme: hst.Proto, Host: hst.Host}
if utilsnet.IsIPv6String(hst.Host) {

This comment has been minimized.

Copy link
@dixudx

dixudx Jan 14, 2020

Member

cmd/kubeadm/app/preflight/checks.go:441:5: undefined: utilsnet

package utilsnet is not imported here.

This comment has been minimized.

Copy link
@rosti

rosti Jan 14, 2020

Author Member

Thanks! Fixed it.

@rosti rosti force-pushed the rosti:automated-cherry-pick-of-#82267-upstream-release-1.15 branch from 73942f3 to 0930f54 Jan 14, 2020
@rosti

This comment has been minimized.

Copy link
Member Author

rosti commented Jan 14, 2020

/kind bug
/priority important-longterm

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jan 14, 2020

i asked here kubernetes/kubeadm#2003 (comment)
if there is an easy workaround using [], if yes and if we are following our principle we should shouldn't backport?

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 18, 2020

/hold all cherry picks are held until resolution of #86182 (tentative next week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.