Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/volume/azure_dd/ #87187

Open
wants to merge 1 commit into
base: master
from

Conversation

@Aresforchina
Copy link
Contributor

Aresforchina commented Jan 14, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref:#81657

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

pkg/volume/azure_dd/azure_common.go:68:2: var winDiskNumFormat is unused (U1000)
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

Hi @Aresforchina. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Jan 14, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aresforchina
To complete the pull request process, please assign brendandburns
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ritazh and sttts Jan 14, 2020
@matthyx

This comment has been minimized.

Copy link
Contributor

matthyx commented Jan 14, 2020

/ok-to-test

@Aresforchina Aresforchina force-pushed the Aresforchina:fix-staticcheck-test17 branch from d980b97 to a6825b0 Jan 15, 2020
@matthyx

This comment has been minimized.

Copy link
Contributor

matthyx commented Jan 15, 2020

/cc

@k8s-ci-robot k8s-ci-robot requested a review from matthyx Jan 15, 2020
@Aresforchina

This comment has been minimized.

Copy link
Contributor Author

Aresforchina commented Jan 16, 2020

/retest

@matthyx

This comment has been minimized.

Copy link
Contributor

matthyx commented Jan 16, 2020

@Aresforchina I think you need to address this error:
ERROR(windows) pkg/volume/azure_dd/azure_common_windows.go:88:27: undeclared name: winDiskNumFormat

@Aresforchina

This comment has been minimized.

Copy link
Contributor Author

Aresforchina commented Jan 16, 2020

@matthyx The variable winDiskNumFormat refer to another file pkg/volume/azure_dd/azure_common_windows.go,it can not being ignoring as an unused var.If so,I will close this pr.

@matthyx

This comment has been minimized.

Copy link
Contributor

matthyx commented Jan 16, 2020

@Aresforchina it's a bit weird how these 2 files are organized... a proper refactoring should be considered.
To skip this error you can also add a comment like:
winDiskNumFormat = "/dev/disk%d" //lint:ignore U1000 used in pkg/volume/azure_dd/azure_common_windows.go

@Aresforchina

This comment has been minimized.

Copy link
Contributor Author

Aresforchina commented Jan 16, 2020

It looks like a good solution and I will adopt this maaner,Thanks!

@Aresforchina Aresforchina force-pushed the Aresforchina:fix-staticcheck-test17 branch 2 times, most recently from 845c657 to b0e9752 Jan 16, 2020
@Aresforchina

This comment has been minimized.

Copy link
Contributor Author

Aresforchina commented Jan 16, 2020

@matthyx it does not skip errors if just add comment in pkg/volume/azure_dd/azure_common.go.because this error just appears as an unused variable and the added comment is useless for skiping error .So I define that var in azure_common_windows.go.please tell me that is this feasible?I am looking forward to your point.

@matthyx

This comment has been minimized.

Copy link
Contributor

matthyx commented Jan 16, 2020

So I define that var in azure_common_windows.go

Makes sense... even it it's weird to have the regex separated from the formatter (probably a smell that both files should merge).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.