Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test images: Image Promoter fixes #87188

Open
wants to merge 1 commit into
base: master
from

Conversation

@claudiubelu
Copy link
Contributor

claudiubelu commented Jan 14, 2020

What type of PR is this?

/kind cleanup
/sig testing
/area conformance

What this PR does / why we need it:

Prior to the Image Centralization part 4 (#81170), a PR merged that enables the Image Promoter to run on the k/k test images.

The Image Promoter currently only builds the Conformance-related images, but the Image Centralization part 4 centralized some of those images into agnhost, so they need to be removed from the conformance_images list.

Additionally, #81226 proposes mounttest-user image to be removed, and RunAsUser to be used in tests instead. This was proposed here: #76342

The image used by the Image Promoter (gcr.io/k8s-testimages/gcb-docker-gcloud:v20190906-745fed4) is based on busybox, and thus, the sed binary is actually busybox. image-util.sh calls kube::util::ensure-gnu-sed several times, which ensures that a GNU sed binary exists (it checks by greping GNU in its --help output). Obviously, it won't match the busybox sed binary. But the sed usage in image-util.sh is fairly simple, and the busybox sed is sufficient.

Bumps image versions for: jessie-dnsutils, nonewprivs, resource-consumer, sample-apiserver. These images are included in the conformance_images that are being built by the Image Promoter, so we're bumping them just to make sure we're not breaking anything and cause all the CIs to fall. We're going to bump the image versions used in tests in a subsequent PR. The image version was not bumped for: agnhost, kitten, nautilus, as they were already bumped by the Image Centralization part 4 PR.

Which issue(s) this PR fixes:

Related: #76342
Related: #81226
Related: #81170
Related: #87251

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Prior to the Image Centralization part 4 (#81170),
a PR merged that enables the Image Promoter to run on the k/k test images.

The Image Promoter currently only builds the Conformance-related images, but the
Image Centralization part 4 centralized some of those images into agnhost, so they
need to be removed from the conformance_images list.

Additionally, #81226 proposes mounttest-user
image to be removed, and RunAsUser to be used in tests instead.

The image used by the Image Promoter (gcr.io/k8s-testimages/gcb-docker-gcloud:v20190906-745fed4)
is based on busybox, and thus, the sed binary is actually busybox. image-util.sh calls
kube::util::ensure-gnu-sed several times, which ensures that a GNU sed binary exists
(it checks by greping GNU in its --help output). Obviously, it won't match the busybox sed
binary. But the sed usage in image-util.sh is fairly simple, and the busybox sed is sufficient.

Bumps image versions for: jessie-dnsutils, nonewprivs, resource-consumer, sample-apiserver. These
images are included in the conformance_images that are being built by the Image Promoter, so
we're bumping them just to make sure we're not breaking anything and cause all the CIs to fall.
We're going to bump the image versions used in tests in a subsequent PR. The image version was not
bumped for: agnhost, kitten, nautilus, as they were already bumped by the Image Centralization part 4
PR.
@claudiubelu

This comment has been minimized.

Copy link
Contributor Author

claudiubelu commented Jan 14, 2020

/test pull-kubernetes-e2e-gce

@claudiubelu claudiubelu force-pushed the claudiubelu:test-images/centralization-cleanup branch from fe6f603 to 0753814 Jan 16, 2020
@claudiubelu claudiubelu changed the title test images: Cleanup after Image Centralization part 4 test images: Image Promoter fixes Jan 16, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 16, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: claudiubelu
To complete the pull request process, please assign soltysh
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@claudiubelu claudiubelu force-pushed the claudiubelu:test-images/centralization-cleanup branch from 0753814 to f81c899 Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Jan 17, 2020
if LANG=C sed --help 2>&1 | grep -q GNU; then
# NOTE: the echo below is a workaround to ensure sed is executed before the grep.
# see: https://github.com/kubernetes/kubernetes/issues/87251
if echo "$(LANG=C sed --help 2>&1)" | grep -q "GNU\|BusyBox"; then

This comment has been minimized.

Copy link
@listx

listx Jan 17, 2020

Contributor

I strongly doubt that the shell runs the piped commands randomly run out-of-order. The stdout logs that we've seen is probably a result of the buffered output being re-combined incorrectly.

This comment has been minimized.

Copy link
@claudiubelu

claudiubelu Jan 17, 2020

Author Contributor

Indeed, it sounds incredible, but it is also the only explanation as to why that function would randonly fail.

This comment has been minimized.

Copy link
@listx

listx Jan 18, 2020

Contributor

Are we sure that this function fails randomly on the same system, and not that the function is failing (seemingly) randomly on different systems that have (or don't have) GNU sed?

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 17, 2020

@claudiubelu: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce f81c899 link /test pull-kubernetes-e2e-gce
pull-kubernetes-verify f81c899 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.