Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove TODO(random-liu): Move pod wait function into this file #87189

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@tanjunchen
Copy link
Member

tanjunchen commented Jan 14, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I think functon GetPodLogs is not the member of framework now.
it belongs to pod subpkg.
run grep -rs "e2epod.GetPodLogs" | wc -l
59
so i want to remove this TODO. Agree?

Which issue(s) this PR fixes:

ref:#86763

Special notes for your reviewer:

/cc @neolit123
/cc @Random-Liu

see https://github.com/kubernetes/kubernetes/pull/77526/files#diff-e1b19b52d8824a95c0d6b3dc22cd6afdR621

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None
@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 14, 2020

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-gce

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jan 14, 2020

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Jan 14, 2020

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 14, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 8568d18 into kubernetes:master Jan 15, 2020
17 checks passed
17 checks passed
cla/linuxfoundation tanjunchen authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 15, 2020
@tanjunchen tanjunchen deleted the tanjunchen:remove-TODO-liuRandom branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.