Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix staticcheck:pkg/controller/daemon and pkg/controller/nodeipam #87190

Open
wants to merge 1 commit into
base: master
from

Conversation

@yuxiaobo96
Copy link
Member

yuxiaobo96 commented Jan 14, 2020

Signed-off-by: yuxiaobo yuxiaobogo@163.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix staticcheck:pkg/controller/daemon and pkg/controller/nodeipam.

Which issue(s) this PR fixes:

ref:#81657

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuxiaobo96
To complete the pull request process, please assign bowei, soltysh
You can assign the PR to them by writing /assign @bowei @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuxiaobo96

This comment has been minimized.

Copy link
Member Author

yuxiaobo96 commented Jan 15, 2020

/retest

@yuxiaobo96

This comment has been minimized.

Copy link
Member Author

yuxiaobo96 commented Jan 15, 2020

/test pull-kubernetes-e2e-gce

1 similar comment
@yuxiaobo96

This comment has been minimized.

Copy link
Member Author

yuxiaobo96 commented Jan 15, 2020

/test pull-kubernetes-e2e-gce

@yuxiaobo96

This comment has been minimized.

Copy link
Member Author

yuxiaobo96 commented Jan 16, 2020

/assign @bowei @soltysh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.