Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for NodeResourceLimits plugin #87192

Merged
merged 1 commit into from Jan 16, 2020

Conversation

@notpad
Copy link
Member

notpad commented Jan 14, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

An integration test for NodeResourceLimits plugin.

Which issue(s) this PR fixes:

Fixes #86926

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig-scheduling
/assign @ahg-g

@notpad

This comment has been minimized.

Copy link
Member Author

notpad commented Jan 14, 2020

/retest

@notpad notpad changed the title An integration test for NodeResourceLimits plugin Add integration test for NodeResourceLimits plugin Jan 14, 2020
@notpad

This comment has been minimized.

Copy link
Member Author

notpad commented Jan 14, 2020

/retest

Copy link
Member

oomichi left a comment

/cc @oomichi

@k8s-ci-robot k8s-ci-robot requested a review from oomichi Jan 14, 2020
@notpad notpad force-pushed the notpad:inte_test branch from f10d255 to 372d09c Jan 15, 2020
@notpad

This comment has been minimized.

Copy link
Member Author

notpad commented Jan 15, 2020

/sig scheduling
/retest

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Jan 15, 2020

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 15, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, notpad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 15, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@notpad

This comment has been minimized.

Copy link
Member Author

notpad commented Jan 15, 2020

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 2b6d875 into kubernetes:master Jan 16, 2020
17 checks passed
17 checks passed
cla/linuxfoundation notpad authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.