Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop tracking managedField on create/update #87196

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@liggitt
Copy link
Member

liggitt commented Jan 14, 2020

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Stops tracking managedField on create/update to clean up CI signal (current pass rate is ~30%).

Which issue(s) this PR fixes:
Fixes #87131

Does this PR introduce a user-facing change?:

NONE

/cc @jennybuckley
/priority critical-urgent
/sig api-machinery

@k8s-ci-robot k8s-ci-robot requested a review from jennybuckley Jan 14, 2020
@liggitt liggitt changed the title Revert fieldmanager Revert 'Enable tracking field management for some objects before they are applied to' Jan 14, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droslean

This comment has been minimized.

Copy link
Member

droslean commented Jan 14, 2020

/lgtm

@jennybuckley

This comment has been minimized.

Copy link
Contributor

jennybuckley commented Jan 14, 2020

We can also address this by changing the test temporarily, like in #87204, which might be preferable since kubernetes-sigs/structured-merge-diff#145 might take a little while to get into k8s/k8s

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 14, 2020

until kubernetes-sigs/structured-merge-diff#145 makes it in, I don't think we should be populating managedFields by default

Lowers probability of managedField population on create/update to 0%
until serialization/normalization issues are resolved
@liggitt liggitt force-pushed the liggitt:revert-fieldmanager branch from d29b56b to ba23aa9 Jan 14, 2020
@k8s-ci-robot k8s-ci-robot added size/XS and removed lgtm size/M labels Jan 14, 2020
@liggitt liggitt changed the title Revert 'Enable tracking field management for some objects before they are applied to' Stop tracking managedField on create/update Jan 14, 2020
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 14, 2020

This can be re-raised once kubernetes-sigs/structured-merge-diff#145 is resolved and updated in kube

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 14, 2020

switched from a revert to a simple lowering of the probability to 0%

@droslean

This comment has been minimized.

Copy link
Member

droslean commented Jan 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 14, 2020
@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Jan 14, 2020

/lgtm

@jennybuckley

This comment has been minimized.

Copy link
Contributor

jennybuckley commented Jan 14, 2020

Sounds good
/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 14, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit bb89c2b into kubernetes:master Jan 14, 2020
16 checks passed
16 checks passed
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 14, 2020
@liggitt liggitt deleted the liggitt:revert-fieldmanager branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.