Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang/mock version to v1.3.1 #87326

Merged
merged 1 commit into from Jan 20, 2020

Conversation

@wawa0210
Copy link
Contributor

wawa0210 commented Jan 17, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
https://github.com/golang/mock/releases

Does this PR introduce a user-facing change?:

Bump golang/mock version to v1.3.1

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 17, 2020

Hi @wawa0210. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, caesarxuchao and kubernetes/dep-approvers Jan 17, 2020
@wawa0210

This comment has been minimized.

Copy link
Contributor Author

wawa0210 commented Jan 17, 2020

/assign @dchen1107

@zhouya0

This comment has been minimized.

Copy link
Member

zhouya0 commented Jan 18, 2020

/ok-to-test

@wawa0210 wawa0210 force-pushed the wawa0210:bump-golang-mock branch from a37032c to 8cbc5dc Jan 18, 2020
@k8s-ci-robot k8s-ci-robot removed the size/XS label Jan 18, 2020
@k8s-ci-robot k8s-ci-robot added the size/S label Jan 18, 2020
@wawa0210

This comment has been minimized.

Copy link
Contributor Author

wawa0210 commented Jan 19, 2020

/test pull-kubernetes-kubemark-e2e-gce-big

@dims

This comment has been minimized.

Copy link
Member

dims commented Jan 19, 2020

@dims

This comment has been minimized.

Copy link
Member

dims commented Jan 19, 2020

/release-note-none
/priority important-soon

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 19, 2020

/lgtm
/approve

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 20, 2020

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, liggitt, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 33aa665 into kubernetes:master Jan 20, 2020
16 checks passed
16 checks passed
cla/linuxfoundation wawa0210 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 20, 2020
@wawa0210 wawa0210 deleted the wawa0210:bump-golang-mock branch Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.