Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce public methods for DryRunVerifier #87489

Merged

Conversation

julianvmodesto
Copy link
Contributor

@julianvmodesto julianvmodesto commented Jan 23, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is a follow up to this PR comment #86408 (review) from @soltysh: we want to expose NewDryRunVerifier and VerifyDryRun in cli-runtime only, and make the internal methods and struct members private:

I'd hide here every bit of implementation except for the methods being used. Namely NewDryRunVerifier and VerifyDryRun. Remember, this is a library and whatever we expose our users will start consuming, thus making it impossible for us to change. Everything about DryRunVerifier struct can be made private and hidden from consumers.

Which issue(s) this PR fixes:

Follow up cleanup for #85652.

Does this PR introduce a user-facing change?:

NONE

/cc @apelisse
/assign @soltysh
/sig cli
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @julianvmodesto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/cli Categorizes an issue or PR as relevant to SIG CLI. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 23, 2020
Copy link
Member

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have a NewDryRunVerifier, you could possibly also hide the variables in DryRunVerifier, so that people don't build it directly?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2020
@julianvmodesto
Copy link
Contributor Author

Since you have a NewDryRunVerifier, you could possibly also hide the variables in DryRunVerifier, so that people don't build it directly?

Done

@julianvmodesto
Copy link
Contributor Author

/assign @apelisse

@apelisse
Copy link
Member

Thanks
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2020
@julianvmodesto
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@julianvmodesto: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@julianvmodesto
Copy link
Contributor Author

/assign @soltysh

@apelisse
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2020
@julianvmodesto
Copy link
Contributor Author

/retest

3 similar comments
@julianvmodesto
Copy link
Contributor Author

/retest

@julianvmodesto
Copy link
Contributor Author

/retest

@julianvmodesto
Copy link
Contributor Author

/retest

@julianvmodesto
Copy link
Contributor Author

PTAL @soltysh

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, julianvmodesto, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2020
@julianvmodesto
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit e8e64a6 into kubernetes:master Feb 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants