New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce public methods for DryRunVerifier #87489
Reduce public methods for DryRunVerifier #87489
Conversation
Hi @julianvmodesto. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you have a NewDryRunVerifier
, you could possibly also hide the variables in DryRunVerifier
, so that people don't build it directly?
dcca5f3
to
18fe96f
Compare
Done |
/assign @apelisse |
Thanks |
/retest |
@julianvmodesto: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @soltysh |
/ok-to-test |
/retest |
3 similar comments
/retest |
/retest |
/retest |
PTAL @soltysh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, julianvmodesto, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is a follow up to this PR comment #86408 (review) from @soltysh: we want to expose
NewDryRunVerifier
andVerifyDryRun
in cli-runtime only, and make the internal methods and struct members private:Which issue(s) this PR fixes:
Follow up cleanup for #85652.
Does this PR introduce a user-facing change?:
/cc @apelisse
/assign @soltysh
/sig cli
/priority important-soon