Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch node authorizer indexes to reference counts, add fastpath edge removal #87696

Merged
merged 3 commits into from Feb 10, 2020

Conversation

@liggitt
Copy link
Member

liggitt commented Jan 30, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Improves node authorizer index maintenance by switching to reference counts and adding a fastpath for edge removal.

Performance compared to current master:

benchmark                            old ns/op      new ns/op      delta
BenchmarkWriteIndexMaintenance-12    875808         8325           -99.05%

benchmark                            old allocs     new allocs     delta
BenchmarkWriteIndexMaintenance-12    41             38             -7.32%

benchmark                            old bytes      new bytes      delta
BenchmarkWriteIndexMaintenance-12    1924           1601           -16.79%

Does this PR introduce a user-facing change?:

Improves performance of the node authorizer

/cc @mikedanese @wojtek-t @mborsz

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Feb 10, 2020

@liggitt - with the underlying PR already merged, can you please rebase it?

@liggitt liggitt force-pushed the liggitt:node2 branch from eeed2d2 to ab69b24 Feb 10, 2020
@liggitt liggitt changed the title WIP - Switch node authorizer indexes to reference counts Switch node authorizer indexes to reference counts, add fastpath edge removal Feb 10, 2020
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 10, 2020

/priority important-longterm

@liggitt liggitt force-pushed the liggitt:node2 branch from ab69b24 to bb2ee8a Feb 10, 2020
@liggitt liggitt force-pushed the liggitt:node2 branch from bb2ee8a to 8a3f587 Feb 10, 2020
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 10, 2020

with the underlying PR already merged, can you please rebase it?

done. suggest reviewing each commit individually (unit tests pass on every individual commit)

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Feb 10, 2020

Nice!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7a506ff into kubernetes:master Feb 10, 2020
15 of 16 checks passed
15 of 16 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 10, 2020
@liggitt liggitt deleted the liggitt:node2 branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.