Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update network-y stuff for supporting ubuntu/bionic #87760

Conversation

@dims
Copy link
Member

dims commented Feb 2, 2020

On bionic, we don't have eth0 hard coded. example below, so we use ip route to figure out the default ethernet interface

dims@kubernetes-master:~$ ip link
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: ens4: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1460 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 42:01:0a:80:00:23 brd ff:ff:ff:ff:ff:ff
3: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default
    link/ether 02:42:b2:4e:dd:86 brd ff:ff:ff:ff:ff:ff

Also, bionic uses systemd-resolver by default and adds entries in
/etc/resolv.conf that CoreDNS does not link. So follow the
recommendation in the documentation to specify resolv.conf explicitly

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@dims dims changed the title update network-y stuff for supporting ubuntu/bionic as master update network-y stuff for supporting ubuntu/bionic Feb 2, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cjcullen and MaciekPytel Feb 2, 2020
@dims dims changed the title update network-y stuff for supporting ubuntu/bionic [WIP] update network-y stuff for supporting ubuntu/bionic Feb 3, 2020
On bionic, we don't have eth0 hard coded. example below, so we use `ip
route` to figure out the default ethernet interface
```
dims@kubernetes-master:~$ ip link
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: ens4: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1460 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 42:01:0a:80:00:23 brd ff:ff:ff:ff:ff:ff
3: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default
    link/ether 02:42:b2:4e:dd:86 brd ff:ff:ff:ff:ff:ff
```

Also, bionic uses systemd-resolver by default and adds entries in
/etc/resolv.conf that CoreDNS does not link. So follow the
recommendation in the documentation to specify resolv.conf explicitly
@dims dims force-pushed the dims:update-network-y-stuff-for-supporting-ubuntu/bionic branch from 28b23d5 to ee3f897 Feb 3, 2020
@dims dims changed the title [WIP] update network-y stuff for supporting ubuntu/bionic update network-y stuff for supporting ubuntu/bionic Feb 3, 2020
@dims

This comment has been minimized.

Copy link
Member Author

dims commented Feb 3, 2020

/test pull-kubernetes-e2e-gce

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Feb 4, 2020

/priority important-soon

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Feb 4, 2020

/assign @aojea @neolit123

@k8s-ci-robot k8s-ci-robot requested a review from chrisohaver Feb 4, 2020
cluster/gce/util.sh Show resolved Hide resolved
cluster/gce/util.sh Show resolved Hide resolved
@aojea

This comment has been minimized.

Copy link
Member

aojea commented Feb 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 4, 2020
@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Feb 4, 2020

@dims dims mentioned this pull request Feb 4, 2020
4 of 4 tasks complete
@k8s-ci-robot k8s-ci-robot merged commit a6a5fc5 into kubernetes:master Feb 5, 2020
16 checks passed
16 checks passed
cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.