Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Default grace period to 0 when --force is used to delete an object #87776
What type of PR is this?
What this PR does / why we need it:
To fix these two problems, this PR eliminates the need to specify
Because I discovered there are several different validation checks performed on various combinations of
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @brianpursley. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
@soltysh: The label(s)
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
3 similar comments
OK it looks like there is some kind of problem blocking the rebuild from succeeding:
I'll investigate later today or tomorrow.