kubectl: allow to preselect interesting container in logs #87809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/assign @soltysh |
k8s-ci-robot
added
area/kubectl
sig/cli
mfojtik
force-pushed
the
kubectl-logs-preselect
branch
from
22dfc3a
to
439f93c
Compare
k8s-ci-robot
added
size/L
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/priority backlog |
k8s-ci-robot
added
priority/backlog
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
php-coder
reviewed
Feb 4, 2020
| // container. This gives users ability to preselect the most interesting container in pod. | ||
| if annotations := t.GetAnnotations(); annotations != nil && len(opts.Container) == 0 && len(annotations[defaultLogsContainerAnnotationName]) > 0 { | ||
| containerName := annotations[defaultLogsContainerAnnotationName] | ||
| if exists, _ := findContainerByName(t, containerName); exists != nil { |
There was a problem hiding this comment.
Should we exclude init and ephemeral containers or there are some use-cases for them too?
There was a problem hiding this comment.
yeah, i would leave it to pod creator to define what he think is the most important container logs he want to see.
|
/test pull-kubernetes-kubemark-e2e-gce-big |
|
/retest |
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
kubectl: allow to preselect interesting container in logs Kubernetes-commit: 7e8f31b
This was referenced Dec 2, 2020
3 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces the
kubectl.kubernetes.io/default-logs-containerannotation that can be placed on aPod. This annotation will causekubectl logsto preselect the container specified as value for this annotation. This helps in case the Pod has multiple containers, but only one container is interesting for logs. In that case, users don't have to pick the container name manually, by using the-coption or--all-containers.Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: