Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add *Options to Create, Update, and Patch in generated clientsets #87952

Merged
merged 4 commits into from Feb 9, 2020

Conversation

@mikedanese
Copy link
Member

mikedanese commented Feb 8, 2020

mikedanese added 4 commits Jan 31, 2020
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 8, 2020

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 8, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikedanese

This comment has been minimized.

Copy link
Member Author

mikedanese commented Feb 8, 2020

Release note for this is folded into release note for #87299

Signatures on generated clientset methods have been modified to accept context.Context as a first argument. Signatures of generated Create, Update, and Patch methods have been updated to accept CreateOptions, UpdateOptions and PatchOptions respectively. Clientsets that with the previous interface have been added in new "deprecated" packages to allow incremental migration to the new APIs. The deprecated packages will be removed in the 1.21 release.

@mikedanese

This comment has been minimized.

Copy link
Member Author

mikedanese commented Feb 8, 2020

/retest

3 similar comments
@mikedanese

This comment has been minimized.

Copy link
Member Author

mikedanese commented Feb 8, 2020

/retest

@mikedanese

This comment has been minimized.

Copy link
Member Author

mikedanese commented Feb 9, 2020

/retest

@mikedanese

This comment has been minimized.

Copy link
Member Author

mikedanese commented Feb 9, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit abe6321 into kubernetes:master Feb 9, 2020
23 of 24 checks passed
23 of 24 checks passed
tide Not mergeable. Retesting: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation mikedanese authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-azure-disk Job succeeded.
Details
pull-kubernetes-e2e-azure-disk-vmss Job succeeded.
Details
pull-kubernetes-e2e-azure-file Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-snapshot Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@mikedanese mikedanese deleted the mikedanese:opts branch Feb 9, 2020
@liggitt liggitt removed the sig/auth label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.