Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register queue metrics in controller manager #87967

Merged

Conversation

@zhan849
Copy link
Contributor

zhan849 commented Feb 9, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind feature

What this PR does / why we need it:
register queue metrics in controller manager

Which issue(s) this PR fixes:

Fixes #87966

Special notes for your reviewer:
"k8s.io/component-base/metrics/prometheus/workqueue" registers prometheus metrics provider to the work queue in its init() function so simply importing the package will have those metrics served.

Does this PR introduce a user-facing change?:

Controller manager serve workqueue metrics

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/assign @cheftako

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 9, 2020

Hi @zhan849. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from lavalamp and stewart-yu Feb 9, 2020
@danielqsj

This comment has been minimized.

Copy link
Member

danielqsj commented Feb 10, 2020

/ok-to-test

@zhan849

This comment has been minimized.

Copy link
Contributor Author

zhan849 commented Feb 10, 2020

/retest

1 similar comment
@zhan849

This comment has been minimized.

Copy link
Contributor Author

zhan849 commented Feb 10, 2020

/retest

@zhan849

This comment has been minimized.

Copy link
Contributor Author

zhan849 commented Feb 10, 2020

seems these tests are passing but gce is having some problems

I0210 04:56:42.655] Will upload results to gs://kubernetes-jenkins/pr-logs using pr-kubekins@kubernetes-jenkins-pull.iam.gserviceaccount.com
I0210 04:56:42.655] Upload result and artifacts...
I0210 04:56:42.655] Gubernator results at https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/87967/pull-kubernetes-e2e-gce-100-performance/1226730031888207872
I0210 04:56:42.655] Call:  gsutil ls gs://kubernetes-jenkins/pr-logs/pull/87967/pull-kubernetes-e2e-gce-100-performance/1226730031888207872/artifacts
W0210 04:56:43.531] CommandException: One or more URLs matched no objects.

/retest

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 10, 2020

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 10, 2020

/assign @logicalhan

@zhan849

This comment has been minimized.

Copy link
Contributor Author

zhan849 commented Feb 10, 2020

/retest

3 similar comments
@zhan849

This comment has been minimized.

Copy link
Contributor Author

zhan849 commented Feb 10, 2020

/retest

@zhan849

This comment has been minimized.

Copy link
Contributor Author

zhan849 commented Feb 10, 2020

/retest

@zhan849

This comment has been minimized.

Copy link
Contributor Author

zhan849 commented Feb 10, 2020

/retest

Copy link
Contributor

logicalhan left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 10, 2020
@zhan849

This comment has been minimized.

Copy link
Contributor Author

zhan849 commented Feb 11, 2020

@logicalhan thanks! can I get an /approve as well so this steps into the merge pool?

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Feb 11, 2020

/cc @cheftako fyi

@k8s-ci-robot k8s-ci-robot requested a review from cheftako Feb 11, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2020

@fedebongio: GitHub didn't allow me to request PR reviews from the following users: fyi.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @cheftako fyi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhan849

This comment has been minimized.

Copy link
Contributor Author

zhan849 commented Feb 12, 2020

@logicalhan thanks! can I get an /approve as well so this steps into the merge pool?

ping @logicalhan @cheftako ^^

@logicalhan

This comment has been minimized.

Copy link
Contributor

logicalhan commented Feb 13, 2020

/priority important-soon

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 13, 2020

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, zhan849

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 029e1a0 into kubernetes:master Feb 14, 2020
16 checks passed
16 checks passed
cla/linuxfoundation zhan849 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.