Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add azure disk migration support on CSINode #88014

Merged
merged 1 commit into from Feb 12, 2020

Conversation

@andyzhangx
Copy link
Member

andyzhangx commented Feb 11, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: add azure disk migration support for CSINode

Which issue(s) this PR fixes:

Fixes #88015

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: add azure disk migration support for CSINode

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/kind bug
/assign @davidz627
/priority important-soon
/sig cloud-provider
/area provider/azure

@andyzhangx andyzhangx requested a review from davidz627 Feb 11, 2020
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali Feb 11, 2020
@andyzhangx andyzhangx changed the title fix: add azure disk migration support for CSINode fix: add azure disk migration support on CSINode Feb 11, 2020
@andyzhangx

This comment has been minimized.

Copy link
Member Author

andyzhangx commented Feb 11, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-csi-serial

Copy link
Member

feiskyer left a comment

/lgtm
/approve

@davidz627

This comment has been minimized.

Copy link
Contributor

davidz627 commented Feb 11, 2020

/lgtm
/approve
/cc @ddebroy
do you think it would be possible/easy to refactor this so that the logic only exists in our new MigrationManager or whatever it was called :)

@k8s-ci-robot k8s-ci-robot requested a review from ddebroy Feb 11, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, davidz627, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidz627

This comment has been minimized.

Copy link
Contributor

davidz627 commented Feb 11, 2020

/retest

1 similar comment
@davidz627

This comment has been minimized.

Copy link
Contributor

davidz627 commented Feb 11, 2020

/retest

@andyzhangx

This comment has been minimized.

Copy link
Member Author

andyzhangx commented Feb 12, 2020

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 92be16c into kubernetes:master Feb 12, 2020
19 checks passed
19 checks passed
cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-snapshot Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 12, 2020
k8s-ci-robot added a commit that referenced this pull request Feb 21, 2020
…8014-upstream-release-1.17

Automated cherry pick of #88014: fix: add azure disk migration support for CSINode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.