Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional from core docs for 'Type' #88029

Merged
merged 3 commits into from Feb 14, 2020

Conversation

@bismitaguha
Copy link
Contributor

bismitaguha commented Feb 11, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Modifies the core/api docs for the Type variable which is not optional.

Which issue(s) this PR fixes:

Fixes #87683

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

This is the default format:

return &corev1.LimitRange{
		ObjectMeta: metadata,
		Spec: corev1.LimitRangeSpec{
			Limits: []corev1.LimitRangeItem{
				{
                                        Type: "Container",
					Max: corev1.ResourceList{corev1.ResourceCPU: resource.MustParse("2.5")},
					Default: corev1.ResourceList{corev1.ResourceCPU: resource.MustParse("2.5")},
					DefaultRequest: corev1.ResourceList{corev1.ResourceCPU: resource.MustParse("2.5")},
				},
			},
		},
	}

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2020

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2020

Welcome @bismitaguha!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2020

Hi @bismitaguha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 11, 2020

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@bismitaguha

This comment has been minimized.

Copy link
Contributor Author

bismitaguha commented Feb 11, 2020

/label api-review

@bismitaguha

This comment has been minimized.

Copy link
Contributor Author

bismitaguha commented Feb 11, 2020

I signed it

@munnerz

This comment has been minimized.

Copy link
Member

munnerz commented Feb 13, 2020

I added a comment to the original issue you opened regarding this PR 😄 #87683 (comment)

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 13, 2020

Thanks for the PR. This looks good to me (see #87683 (comment) for context).

You will need to regenerate the protobuf and openapi docs for this API using make update, then commit the results.

@k8s-ci-robot k8s-ci-robot added sig/auth and removed needs-sig labels Feb 13, 2020
@bismitaguha

This comment has been minimized.

Copy link
Contributor Author

bismitaguha commented Feb 13, 2020

@liggitt I have run make update and make verify and committed the results. Please review the changes.

@@ -96,7 +96,7 @@ func (DaemonSetSpec) SwaggerDoc() map[string]string {
}

var map_DaemonSetStatus = map[string]string{
"": "DaemonSetStatus represents the current status of a daemon set.",
"": "DaemonSetStatus represents the current status of a daemon set.",

This comment has been minimized.

Copy link
@liggitt

liggitt Feb 13, 2020

Member

all of the whitespace changes are unexpected... what go version are you running with? try running hack/update-gofmt.sh before committing

This comment has been minimized.

Copy link
@bismitaguha

bismitaguha Feb 13, 2020

Author Contributor

go1.13.7

This comment has been minimized.

Copy link
@bismitaguha

bismitaguha Feb 13, 2020

Author Contributor

@liggitt I have properly run all the above mentioned scripts and committed the changes. Please review.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 14, 2020

/sig node
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bismitaguha, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 14, 2020

@bismitaguha: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 4970a4e link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit a20ae39 into kubernetes:master Feb 14, 2020
15 of 16 checks passed
15 of 16 checks passed
pull-kubernetes-e2e-gce-device-plugin-gpu Job failed.
Details
cla/linuxfoundation bismitaguha authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.