Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up connection onClose prior to adding to connection map #88079

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@liggitt
Copy link
Member

liggitt commented Feb 12, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Ensures all connections opened by the connrotation utility have a non-nil onClose method prior to assigning them to the connection map.

Which issue(s) this PR fixes:
Fixes #88063

Does this PR introduce a user-facing change?:

Fixes kubelet crash in client certificate rotation cases

/assign @awly
/sig auth node

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 12, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot requested review from deads2k and lavalamp Feb 12, 2020
@liggitt liggitt force-pushed the liggitt:onclose-panic branch from f4c2c5e to 910636e Feb 12, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 12, 2020

/retest

@liggitt liggitt force-pushed the liggitt:onclose-panic branch from 910636e to aa4113d Feb 12, 2020
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 12, 2020

done

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 13, 2020

runc race
/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 13, 2020

/retest

Copy link
Contributor

mattjmcnaughton left a comment

/lgtm

ty for this fix and for the regression test.

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 13, 2020
@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

mattjmcnaughton commented Feb 13, 2020

/assign @smarterclayton

@awly

This comment has been minimized.

Copy link
Contributor

awly commented Feb 13, 2020

/lgtm

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 13, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b2bf4a8 into kubernetes:master Feb 14, 2020
16 checks passed
16 checks passed
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 14, 2020
@liggitt liggitt deleted the liggitt:onclose-panic branch Feb 14, 2020
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 14, 2020

cherry-picks updated with comments

k8s-ci-robot added a commit that referenced this pull request Feb 21, 2020
…9-upstream-release-1.15

Automated cherry pick of #88079: Set up connection onClose prior to adding to connection map
k8s-ci-robot added a commit that referenced this pull request Feb 21, 2020
…9-upstream-release-1.17

Automated cherry pick of #88079: Set up connection onClose prior to adding to connection map
k8s-ci-robot added a commit that referenced this pull request Feb 21, 2020
…9-upstream-release-1.16

Automated cherry pick of #88079: Set up connection onClose prior to adding to connection map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.