Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: e2e_node: refactor getCurrentKubeletConfig #88110

Open
wants to merge 3 commits into
base: master
from

Conversation

@fromanirh
Copy link
Contributor

fromanirh commented Feb 13, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Refactoring to de-dup the getCurrentKubeletConfig helper which is used by both e2e and e2e_node tests. This patch originated because we want to add more topology manager e2e tests, and the function started to proliferate too much. See #88107

Which issue(s) this PR fixes:
Related to #83481

Special notes for your reviewer:
This patch works for me running e2e_node tests locally, but I don't have windows machine available.

Does this PR introduce a user-facing change?:

NONE
this patch moves the helper getCurrentKubeletConfig function,
used in both e2e and e2e_node tests and previously duplicated,
in the common framework.

There are no intended changes in behaviour.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 13, 2020

Hi @fromanirh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fromanirh

This comment has been minimized.

Copy link
Contributor Author

fromanirh commented Feb 13, 2020

/sig testing

@fromanirh

This comment has been minimized.

Copy link
Contributor Author

fromanirh commented Feb 13, 2020

/assign cblecker

@k8s-ci-robot k8s-ci-robot requested a review from oomichi Feb 14, 2020
Address review comments and move the helper function
in the `framework/kubelet` package to avoid circular deps
(see #81245)

Signed-off-by: Francesco Romani <fromani@redhat.com>
@fromanirh

This comment has been minimized.

Copy link
Contributor Author

fromanirh commented Feb 14, 2020

not sure who can review/approve from windows side @michmike and @PatrickLang (according to the OWNERS file) could you please help?

@oomichi

This comment has been minimized.

Copy link
Member

oomichi commented Feb 14, 2020

Thanks for updating.

/ok-to-test

@oomichi

This comment has been minimized.

Copy link
Member

oomichi commented Feb 14, 2020

Need to run ./hack/update-bazel.sh for passing pull-kubernetes-verify job.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@fromanirh

This comment has been minimized.

Copy link
Contributor Author

fromanirh commented Feb 18, 2020

/sig node

@PatrickLang

This comment has been minimized.

Copy link
Contributor

PatrickLang commented Feb 18, 2020

/assign
Will test on Windows

@oomichi

This comment has been minimized.

Copy link
Member

oomichi commented Feb 18, 2020

Thanks for updating.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 18, 2020
@PatrickLang PatrickLang added this to In Review (v1.18) in SIG-Windows Feb 20, 2020
@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Feb 20, 2020

/approve

/hold

@PatrickLang when you have a chance to confirm, please remove the hold.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 20, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: derekwaynecarr, fromanirh
To complete the pull request process, please assign cblecker
You can assign the PR to them by writing /assign @cblecker in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
SIG-Windows
  
In Review (v1.18)
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.