Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rate limiter latency logging and add component-base metric #88134

Open
wants to merge 1 commit into
base: master
from

Conversation

@jennybuckley
Copy link
Contributor

jennybuckley commented Feb 13, 2020

What type of PR is this?
/sig api-machinery
/priority important-soon
/kind feature
/cc @lavalamp

What this PR does / why we need it:
Follow up to #87740

Adds a more severe and infrequent log message as suggested in #87740 (comment)

Also adds a new client-go metric to track the rate limiter latency across all invocations.

Does this PR introduce a user-facing change?:

Add `rest_client_rate_limiter_duration_seconds` metric to component-base to track client side rate limiter latency in seconds. Broken down by verb and URL.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 13, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jennybuckley
To complete the pull request process, please assign logicalhan, smarterclayton
You can assign the PR to them by writing /assign @logicalhan @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jennybuckley

This comment has been minimized.

Copy link
Contributor Author

jennybuckley commented Feb 13, 2020

/retest

@jennybuckley

This comment has been minimized.

Copy link
Contributor Author

jennybuckley commented Feb 13, 2020

/cc @logicalhan
Does this seem reasonable?

@k8s-ci-robot k8s-ci-robot requested a review from logicalhan Feb 13, 2020
@jennybuckley jennybuckley changed the title Improve rate limiter latency logging and metrics Improve rate limiter latency logging and add component-base metric Feb 13, 2020
@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Feb 18, 2020

/assign @logicalhan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.