Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scheduler Framework]Remove `FilteredNodesStatuses` argument from `PreScore`'s interface #88189

Merged

Conversation

@skilxn-go
Copy link
Contributor

skilxn-go commented Feb 15, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
For keeping semantically correct, PreScore plugins don't need to know the output of filtering, aka the argument FilteredNodesStatuses.

Which issue(s) this PR fixes:

Fixes #87523

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove `FilteredNodesStatuses` argument from `PreScore`'s interface.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP] https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/20180409-scheduling-framework.md
@skilxn-go skilxn-go force-pushed the skilxn-go:RemovePreScoreNodeListArguments branch from 2499c20 to 8fd0d80 Feb 15, 2020
@skilxn-go

This comment has been minimized.

Copy link
Contributor Author

skilxn-go commented Feb 15, 2020

/retest
/assign @alculquicondor

@alculquicondor

This comment has been minimized.

Copy link
Member

alculquicondor commented Feb 15, 2020

Just to be clear on the PR description: It's not about it being informative (the alternative would be to make a clone before passing the map). It's about being semantically correct: scoring doesn't need to know the output of filtering.

@alculquicondor

This comment has been minimized.

Copy link
Member

alculquicondor commented Feb 15, 2020

/approve

Please fix the PR description :)

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, skilxn-go

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skilxn-go

This comment has been minimized.

Copy link
Contributor Author

skilxn-go commented Feb 15, 2020

I have updated the description. Thanks for pointing out my mistake. :D

@alculquicondor

This comment has been minimized.

Copy link
Member

alculquicondor commented Feb 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 15, 2020
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 15, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@danwinship

This comment has been minimized.

Copy link
Contributor

danwinship commented Feb 15, 2020

/uncc
/remove-sig network

@k8s-ci-robot k8s-ci-robot removed the request for review from danwinship Feb 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3b22fcc into kubernetes:master Feb 15, 2020
17 checks passed
17 checks passed
cla/linuxfoundation skilxn-go authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 15, 2020
@skilxn-go skilxn-go deleted the skilxn-go:RemovePreScoreNodeListArguments branch Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.