Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
run permit plugins in the scheduling cycle #88199
What type of PR is this?
What this PR does / why we need it:
Scheduler framework permit plugins now run at the end of the scheduling cycle, after reserve plugins. Waiting on permit will remain in the beginning of the binding cycle.
This change guarantees the intuitive order in which permit plugins will be executed. If pod should wait on permit, then pod will be added to the waiting pods map before permit plugins are executed for another pod. This change removes subtle races between creation of and rejecting/allowing waiting pod and simplifies implementation of some potential permit plugins e.g. co-scheduling plugins.
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
Hi @mateuszlitwin. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing