Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present more concrete information about pod readiness #88240

Merged
merged 1 commit into from Mar 3, 2020

Conversation

@soltysh
Copy link
Contributor

soltysh commented Feb 17, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Currently it does not matter if a pod is running or not we will blindly set its state to Running when you invoke kubectl get pods, even though in pod's conditions it's clearly not ready. This takes that particular condition into consideration when printing that information.

/assign @smarterclayton

Does this PR introduce a user-facing change?:

Print NotReady when pod is not ready based on its conditions.
@soltysh

This comment has been minimized.

Copy link
Contributor Author

soltysh commented Feb 17, 2020

/sig cli
/priority backlog

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Feb 17, 2020

I like this approach, I think it is much more useful when scanning the list of pods. NotReady is a fundamental aspect of pods that overrides / overrules the phase in specific contexts.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Mar 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit bfb3fb5 into kubernetes:master Mar 3, 2020
16 checks passed
16 checks passed
cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 3, 2020
@soltysh soltysh deleted the soltysh:pod_conditions branch Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.