Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dry-run=server|client|none to more kubectl commands #88292

Merged
merged 1 commit into from Feb 21, 2020

Conversation

@julianvmodesto
Copy link
Contributor

julianvmodesto commented Feb 18, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds the --dry-run flag for client-side and server-side dry-run to kubectl commands:

  • delete
  • taint
  • replace

Dry-running these commands is useful to see what would happen without persisting the change.

Which issue(s) this PR fixes:

Part of #85652

Does this PR introduce a user-facing change?:

Add --dry-run to kubectl delete, taint, replace

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/0015-dry-run.md

/sig cli
cc @apelisse
/priority important-soon

@julianvmodesto

This comment has been minimized.

Copy link
Contributor Author

julianvmodesto commented Feb 18, 2020

/assign @apelisse

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Feb 19, 2020

That looked good. I don't know why that test failed, let's retry
/retest

@julianvmodesto

This comment has been minimized.

Copy link
Contributor Author

julianvmodesto commented Feb 19, 2020

/retest

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Feb 19, 2020

- delete
- taint
- replace
@julianvmodesto

This comment has been minimized.

Copy link
Contributor Author

julianvmodesto commented Feb 20, 2020

/retest

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Feb 20, 2020

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 20, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, julianvmodesto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1591590 into kubernetes:master Feb 21, 2020
17 checks passed
17 checks passed
cla/linuxfoundation julianvmodesto authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.