Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init containers log to cluster dump info #88324

Merged

Conversation

@zhouya0
Copy link
Member

zhouya0 commented Feb 19, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Add init-container to cluster dump info. I believe the this #44088 PR hasn't consider add init-container since the feature of init-container is not GA at that moment. Someone has point out this and I think it's ok to add the init-container log. Like #88310 said.
Which issue(s) this PR fixes:

Fixes ##88310

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add init containers log to cluster dump info.
@zhouya0

This comment has been minimized.

Copy link
Member Author

zhouya0 commented Feb 20, 2020

/assign @mengqiy

Copy link
Contributor

soltysh left a comment

/lgtm
/approve
/kind bug
/priority backlog

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, zhouya0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0e9a848 into kubernetes:master Feb 22, 2020
16 checks passed
16 checks passed
cla/linuxfoundation zhouya0 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.