Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate service annotation service.beta.kubernetes.io/azure-load-balancer-disable-tcp-reset #88462

Merged
merged 1 commit into from Feb 24, 2020

Conversation

@feiskyer
Copy link
Member

feiskyer commented Feb 24, 2020

…lancer-disable-tcp-reset

What type of PR is this?

/kind deprecation
/sig cloud-provider
/area provider-azure
/priority important-soon

What this PR does / why we need it:

Mark service annotation service.beta.kubernetes.io/azure-load-balancer-disable-tcp-reset as deprecated and log a waring log for it.

Which issue(s) this PR fixes:

Fixes kubernetes-sigs/cloud-provider-azure#302

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Azure service annotation service.beta.kubernetes.io/azure-load-balancer-disable-tcp-reset has been deprecated. Its support would be removed in a future release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


…lancer-disable-tcp-reset
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 24, 2020

@feiskyer: The label(s) area/provider-azure cannot be applied, because the repository doesn't have them

In response to this:

…lancer-disable-tcp-reset

What type of PR is this?

/kind deprecation
/sig cloud-provider
/area provider-azure
/priority important-soon

What this PR does / why we need it:

Mark service annotation service.beta.kubernetes.io/azure-load-balancer-disable-tcp-reset as deprecated and log a waring log for it.

Which issue(s) this PR fixes:

Fixes kubernetes-sigs/cloud-provider-azure#302

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Azure service annotation service.beta.kubernetes.io/azure-load-balancer-disable-tcp-reset has been deprecated. Its support would be removed in a future release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer feiskyer added this to In progress in Provider Azure via automation Feb 24, 2020
@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented Feb 24, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 24, 2020
@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented Feb 24, 2020

/assign @andyzhangx

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented Feb 24, 2020

/area provider/azure

Copy link
Member

andyzhangx left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 24, 2020
Copy link
Member

andyzhangx left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 94837da into kubernetes:master Feb 24, 2020
20 checks passed
20 checks passed
cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-azure-disk Job succeeded.
Details
pull-kubernetes-e2e-azure-disk-vmss Job succeeded.
Details
pull-kubernetes-e2e-azure-file Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Provider Azure automation moved this from In progress to Done Feb 24, 2020
@feiskyer feiskyer deleted the feiskyer:fix-302 branch Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.