Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AppProtocol to Service and Endpoints Ports #88503

Merged
merged 1 commit into from Feb 26, 2020

Conversation

@robscott
Copy link
Member

robscott commented Feb 25, 2020

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This adds the AppProtocol field to Service and Endpoints resources, gated by a new ServiceAppProtocol feature gate.

Does this PR introduce a user-facing change?:

AppProtocol is a new field on Service and Endpoints resources, enabled with the ServiceAppProtocol feature gate.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig network
/priority important-soon
/cc @liggitt
/assign @thockin

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 25, 2020

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

Copy link
Member

thockin left a comment

Thanks!

/lgtm
/approve

pkg/apis/core/types.go Outdated Show resolved Hide resolved
pkg/apis/core/types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 26, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott

This comment has been minimized.

Copy link
Member Author

robscott commented Feb 26, 2020

Thanks for the review and approval! Holding temporarily to fix my typo.

/hold

@robscott robscott force-pushed the robscott:app-protocol branch from 79eb74e to 6a33727 Feb 26, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 26, 2020
@robscott

This comment has been minimized.

Copy link
Member Author

robscott commented Feb 26, 2020

/hold cancel

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Feb 26, 2020

/lgtm

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 26, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 86141c0 into kubernetes:master Feb 26, 2020
17 checks passed
17 checks passed
cla/linuxfoundation robscott authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.