Update Golang to v1.14.4 #88638

justaugustus · 2020-02-28T00:05:46Z

What type of PR is this?
/kind cleanup
/area dependency release-eng
/sig release

What this PR does / why we need it:
Update Golang to v1.14.4

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @liggitt @cblecker @dims @BenTheElder @listx
cc: @kubernetes/release-engineering
ref: kubernetes/release#1216

Does this PR introduce a user-facing change?:

Update Golang to v1.14.4

justaugustus · 2020-02-28T00:06:07Z

/priority important-soon

justaugustus · 2020-02-28T00:09:23Z

pull-kubernetes-cross is an expected failure as the kube-cross image for go1.14.0 doesn't exist yet.
Once this PR passes other tests, I'll build and promote the new kube-cross image.

mm4tt · 2020-02-28T09:06:45Z

FTR, SIG Scalability worked with golang folks on 1.14 release qualification - golang/go#36752
We had some performance regressions but they have been fixed and golang1.14 is good to go from the scalability/performance perspective.

@justaugustus, for the future, could you add someone from sig-scalability when you update golang to new minor version to double check? This time we managed to beat the regression before first minor release, but for 1.13 a few first patch releases were not good from scale perspective (see golang/go#32828, IIRC 1.13.3 was the first good release).

Thanks!

liggitt · 2020-02-28T22:02:27Z

looks like etcd tests are unhappy with go1.14:

$ go test -race k8s.io/apiserver/pkg/storage/etcd3 |& pp
fatal error: checkptr: unsafe pointer conversion
FAIL	k8s.io/apiserver/pkg/storage/etcd3	0.238s
FAIL
1: running [Created by integration.(*cluster).Launch @ cluster.go:223]
    runtime     panic.go:1112         throw(string(0x2375c38, len=35))
    runtime     checkptr.go:18        checkptrAlignment(Pointer(0xc0002c2130), *_type(0x1))
    bbolt       bucket.go:624         (*Bucket).write(*Bucket(0xc0002bf220), 0x0, 0x0, 0x0)
    bbolt       bucket.go:181         (*Bucket).CreateBucket(*Bucket(0xc000202478), []byte(#1 len=7 cap=7), 0xc0002bf480, 0x1e17936, 0xc000298978)
    bbolt       tx.go:108             (*Tx).CreateBucket(...)
    backend     batch_tx.go:72        (*batchTx).UnsafeCreateBucket(*batchTx(#4), []byte(#1 len=7 cap=7))
    backend     <autogenerated>:1     (*batchTxBuffered).UnsafeCreateBucket(#4, #1, 0x7, 0x7)
    membership  store.go:166          mustCreateBackendBuckets(Backend(0x25e26c0))
    membership  cluster.go:242        (*RaftCluster).SetBackend(...)
    etcdserver  server.go:406         NewServer(ServerConfig(0xc0001d9ca0), 0x0, 0x0, 0x0, 0x0, 0xc00020eb00, 0x1, 0x1, 0xc00020e880, ...)
    integration cluster.go:801        (*member).Launch(*member(#3), 0x0, 0x0)
    integration cluster.go:224        (*cluster).Launch.func1(*cluster(0xc000190900), TB(#3))
    runtime     asm_amd64.s:1373      goexit()

xref etcd-io/bbolt#187

cc @enj @jpbetz

enj · 2020-02-28T22:04:57Z

looks like etcd tests are unhappy with go1.14

If we want to be terrible people, we can do -gcflags=all=-d=checkptr=0 per the release notes to turn off the new check. I do not know how that flags interacts with -race.

jpbetz · 2020-02-29T00:08:46Z

The improved pointer checking in 1.14 is trying to help us here. We should trace these down and get etcd to be fully compliant.

…

On Fri, Feb 28, 2020 at 2:05 PM Mo Khan ***@***.***> wrote: looks like etcd tests are unhappy with go1.14 If we want to be terrible people, we can do -gcflags=all=-d=checkptr=0 per the release notes <https://golang.org/doc/go1.14#compiler> to turn off the new check. I do not know how that flags interacts with -race. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#88638?email_source=notifications&email_token=AAD72RSQOZDMKGPY24OQZDDRFGDAXA5CNFSM4K5F2IQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENKKNOI#issuecomment-592750265>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD72RVGOTA4ZJNC5C76MATRFGDAXANCNFSM4K5F2IQQ> .

listx · 2020-03-07T02:01:45Z

I suppose this PR is blocked on forthcoming(?) etcd fixes...?

RainbowMango · 2020-03-07T02:07:38Z

We'd better take a look at the mlock issue before update to v1.14.

k8s-ci-robot · 2020-06-22T23:07:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~build/OWNERS~~ [cblecker,fejta,liggitt]
~~staging/src/k8s.io/apiserver/pkg/apis/OWNERS~~ [liggitt]
~~test/images/OWNERS~~ [cblecker,fejta,liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

justaugustus · 2020-06-22T23:42:09Z

/test pull-kubernetes-e2e-kind-ipv6

k8s-ci-robot · 2020-06-23T00:33:42Z

@justaugustus: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-kind-ipv6	`b0f17c2`	link	`/test pull-kubernetes-e2e-kind-ipv6`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

justaugustus · 2020-06-23T00:56:05Z

/test pull-kubernetes-e2e-kind-ipv6

justaugustus · 2020-06-23T01:00:34Z

F I N A L L Y .
/honk
/pony party

k8s-ci-robot · 2020-06-23T01:00:35Z

@justaugustus:

In response to this:

F I N A L L Y .
/honk
/pony party

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-06-23T01:00:41Z

@justaugustus:

In response to this:

F I N A L L Y .
/honk
/pony party

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

RainbowMango · 2020-06-23T01:48:34Z

Congrats! It's quite a long ride!

The kubernetes project has been updated to use Go 1.14.4. See below pull request. kubernetes/kubernetes#88638 After making the updates to Go 1.14 "make gen" no longer worked. The file hack/tools.go had to be created to get "make gen" working with Go 1.14.

BenTheElder · 2020-06-23T05:28:16Z

reminder that the IPV6 job is not required for merge 🙃

…

On Mon, Jun 22, 2020 at 6:48 PM Hongcai Ren ***@***.***> wrote: Congrats! It's quite a long ride! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#88638 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHADK4H4BIQBNAFGOMXZADRYACYDANCNFSM4K5F2IQQ> .

The kubernetes project has been updated to use Go 1.14.4. See below pull request. kubernetes/kubernetes#88638 After making the updates to Go 1.14 "make gen" no longer worked. The file hack/tools.go had to be created to get "make gen" working with Go 1.14.

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2020

k8s-ci-robot assigned BenTheElder Feb 28, 2020

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 28, 2020

k8s-ci-robot assigned cblecker, dims and liggitt Feb 28, 2020

k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 28, 2020

k8s-ci-robot assigned listx Feb 28, 2020

k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 28, 2020

k8s-ci-robot requested review from BenTheElder and fejta February 28, 2020 00:07

k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 28, 2020

justaugustus mentioned this pull request Feb 28, 2020

Quarterly golang updates (Kubernetes 1.15 through 1.19 (master) branches) kubernetes/release#1134

Closed

25 tasks

prestonvanloon mentioned this pull request Feb 28, 2020

Update to go 1.14 prysmaticlabs/prysm#4947

Merged

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020

k8s-ci-robot merged commit f2534f2 into kubernetes:master Jun 23, 2020

k8s-ci-robot added this to the v1.19 milestone Jun 23, 2020

This was referenced Jun 23, 2020

k8s-cloud-builder: Build cross1.14 variant on kube-cross:v1.14.4-2 kubernetes/release#1374

Merged

releng: Update variants (kubekins, krte) to use go1.14.4 kubernetes/test-infra#18047

Merged

seanmalloy mentioned this pull request Jun 23, 2020

Update To Go 1.14.4 kubernetes-sigs/descheduler#328

Merged

damemi mentioned this pull request Jun 23, 2020

Update descheduler prow jobs to go 1.14.4 kubernetes/test-infra#18054

Merged

liggitt mentioned this pull request Jun 23, 2020

go1.14 fixup #92438

Merged

github-actions bot mentioned this pull request Jun 23, 2020

Week Ending June 21, 2020 dev-obs/actus#183

Open

This was referenced Jun 24, 2020

Bump default go version to 1.14.4 kubernetes/publishing-bot#230

Merged

devel: update required Go versions kubernetes/community#4885

Merged

Update pull-client-go-build to go1.14.4 kubernetes/test-infra#18066

Merged

liggitt mentioned this pull request Jun 25, 2020

consider setting GODEBUG=asyncpreemptoff=1 #92521

Closed

github-actions bot mentioned this pull request Jun 30, 2020

Week Ending June 28, 2020 dev-obs/actus#187

Open

fisherxu mentioned this pull request Jul 1, 2020

update golang to 1.14 kubeedge/kubeedge#1539

Merged

haircommander mentioned this pull request Jul 2, 2020

kubelet consistently timing out on attempting to Destroy cgroups #92766

Closed

rifelpet mentioned this pull request Jul 5, 2020

Upgrade to go 1.14.4 kubernetes/kops#9499

Merged

mogren mentioned this pull request Aug 18, 2020

go 1.15 was just released. We should at least bump to 1.14 aws/amazon-vpc-cni-k8s#1133

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Golang to v1.14.4 #88638

Update Golang to v1.14.4 #88638

justaugustus commented Feb 28, 2020 •

edited

justaugustus commented Feb 28, 2020

justaugustus commented Feb 28, 2020

mm4tt commented Feb 28, 2020

liggitt commented Feb 28, 2020

enj commented Feb 28, 2020

jpbetz commented Feb 29, 2020 via email

listx commented Mar 7, 2020

RainbowMango commented Mar 7, 2020

k8s-ci-robot commented Jun 22, 2020

justaugustus commented Jun 22, 2020

k8s-ci-robot commented Jun 23, 2020

justaugustus commented Jun 23, 2020

justaugustus commented Jun 23, 2020

k8s-ci-robot commented Jun 23, 2020

k8s-ci-robot commented Jun 23, 2020

RainbowMango commented Jun 23, 2020

BenTheElder commented Jun 23, 2020 via email

Update Golang to v1.14.4 #88638

Update Golang to v1.14.4 #88638

Conversation

justaugustus commented Feb 28, 2020 • edited

justaugustus commented Feb 28, 2020

justaugustus commented Feb 28, 2020

mm4tt commented Feb 28, 2020

liggitt commented Feb 28, 2020

enj commented Feb 28, 2020

jpbetz commented Feb 29, 2020 via email

listx commented Mar 7, 2020

RainbowMango commented Mar 7, 2020

k8s-ci-robot commented Jun 22, 2020

justaugustus commented Jun 22, 2020

k8s-ci-robot commented Jun 23, 2020

justaugustus commented Jun 23, 2020

justaugustus commented Jun 23, 2020

k8s-ci-robot commented Jun 23, 2020

k8s-ci-robot commented Jun 23, 2020

RainbowMango commented Jun 23, 2020

BenTheElder commented Jun 23, 2020 via email

justaugustus commented Feb 28, 2020 •

edited