Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add default constraints to PodTopologySpread plugin #88671
What type of PR is this?
What this PR does / why we need it:
Adds ability to set default constraints for the
With this PR, k8s is not setting any defaults.
However, I updated the benchmark that compares
Which gives a difference of 3x for 100 nodes and 2.7x for 1000 nodes. So we maintain the same complexity but with different constant #84936. I don't think we are ready to add the k8s default this release.
Which issue(s) this PR fixes:
Part of #80639
Special notes for your reviewer:
Note that the changes only affect
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alculquicondor
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
alculquicondor left a comment
Added a comment. PodTopologySpread with a default and DefaultPodTopologySpread aren't supposed to co-exist. I'll make sure to include this in the documentation.