Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide kubectl.kubernetes.io/last-applied-configuration in describe #88758

Merged
merged 2 commits into from Mar 4, 2020

Conversation

@soltysh
Copy link
Contributor

soltysh commented Mar 3, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR has 2 elements:

  1. It hides extremely verbose kubectl.kubernetes.io/last-applied-configuration in describe command, users can always access that directly through yaml or json, if needed.
  2. Squashes pkg/describe/versioned/ into pkg/describe/ for simplicity.

Special notes for your reviewer:
/assign @sallyom @smarterclayton

Does this PR introduce a user-facing change?:

Hide kubectl.kubernetes.io/last-applied-configuration in describe command
@soltysh

This comment has been minimized.

Copy link
Contributor Author

soltysh commented Mar 3, 2020

/sig cli
/priority backlog

@soltysh soltysh force-pushed the soltysh:hide_last_applied branch from ca656e9 to 02cd65d Mar 3, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sallyom

This comment has been minimized.

Copy link
Contributor

sallyom commented Mar 3, 2020

/lgtm (see golint errs, though, then i'll retag)

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 3, 2020
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 4, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 0535520 into kubernetes:master Mar 4, 2020
16 checks passed
16 checks passed
cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 4, 2020
@soltysh soltysh deleted the soltysh:hide_last_applied branch Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.