Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress: allow wildcard hosts in IngressRule #88858

Merged
merged 1 commit into from Mar 5, 2020

Conversation

@cmluciano
Copy link
Member

cmluciano commented Mar 5, 2020

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This PR tests that wildcard hosts are accepted and updates the types documentation to explicitly state the support of wildcard hosts

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

ingress: allow wildcard hosts in IngressRule

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Ingress KEP

@cmluciano

This comment has been minimized.

Copy link
Member Author

cmluciano commented Mar 5, 2020

/assign @robscott @liggitt

This should be the final PR for the planned 1.18 Ingress changes

Copy link
Member

liggitt left a comment

one doc nit, lgtm otherwise

pkg/apis/networking/types.go Show resolved Hide resolved
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 5, 2020

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt liggitt added this to the v1.18 milestone Mar 5, 2020
@liggitt liggitt added this to API review completed, 1.18 in API Reviews Mar 5, 2020
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 5, 2020

/priority important-soon

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
@cmluciano cmluciano force-pushed the cmluciano:cml/hostnamewildcard branch from fd79de3 to e931e30 Mar 5, 2020
@cmluciano cmluciano requested a review from liggitt Mar 5, 2020
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 5, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 5, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8508875 into kubernetes:master Mar 5, 2020
16 checks passed
16 checks passed
cla/linuxfoundation cmluciano authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
API Reviews
API review completed, 1.18
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.