Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata client: plumb context #88910

Merged
merged 2 commits into from Mar 6, 2020
Merged

Conversation

@liggitt
Copy link
Member

liggitt commented Mar 6, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Plumbs context to the metadata client. Part of https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20200123-client-go-ctx.md

Does this PR introduce a user-facing change?:

Signatures on the metadata client methods have been modified to accept `context.Context` as a first argument. Signatures of Delete and DeleteCollection methods now accept DeleteOptions by value instead of by reference.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20200123-client-go-ctx.md

/sig api-machinery
/cc @mikedanese

liggitt added 2 commits Mar 6, 2020
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 6, 2020

/priority important-soon
/milestone v1.18
/hold for exception request https://groups.google.com/forum/#!topic/kubernetes-sig-release/0Vl7My_ElgY

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikedanese

This comment has been minimized.

Copy link
Member

mikedanese commented Mar 6, 2020

/lgtm

@enj

This comment has been minimized.

Copy link
Member

enj commented Mar 6, 2020

/lgtm

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 6, 2020

/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Mar 6, 2020

/hold cancel

Exception approved

@k8s-ci-robot k8s-ci-robot merged commit f52cbea into kubernetes:master Mar 6, 2020
18 checks passed
18 checks passed
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ga-only-parallel Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@liggitt liggitt deleted the liggitt:metadata-context branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.