Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeCIDR for detect-local-mode #88935

Merged
merged 1 commit into from Mar 9, 2020
Merged

Conversation

@satyasm
Copy link
Contributor

satyasm commented Mar 7, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adding support for NodeCIDR as per https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20191104-iptables-no-cluster-cidr.md

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
yes

Adds support for NodeCIDR as an argument to --detect-local-mode

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20191104-iptables-no-cluster-cidr.md

Adds support for nodeCIDR as argument to --detect-local-mode to use per node PodCIDR
for detecting traffic, instead of ClusterCIDR.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 7, 2020

Hi @satyasm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/network and removed needs-sig labels Mar 7, 2020
@satyasm satyasm force-pushed the satyasm:kep-local-cidr branch from 4248aa1 to 692fb24 Mar 7, 2020
@k8s-ci-robot k8s-ci-robot requested review from dcbw and nicksardo Mar 7, 2020
@satyasm

This comment has been minimized.

Copy link
Contributor Author

satyasm commented Mar 7, 2020

/assign @thockin

@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented Mar 7, 2020

/ok-to-test

@satyasm satyasm force-pushed the satyasm:kep-local-cidr branch from 692fb24 to 5663e1a Mar 7, 2020
@satyasm

This comment has been minimized.

Copy link
Contributor Author

satyasm commented Mar 7, 2020

/milestone v1.18

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 7, 2020

@satyasm: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@satyasm

This comment has been minimized.

Copy link
Contributor Author

satyasm commented Mar 7, 2020

@thockin we want this in v1.18 and need to add milestone label to it too. Looks I don't have the permissions to do so.

Copy link
Member

thockin left a comment

minor stuff

cmd/kube-proxy/app/server_others.go Show resolved Hide resolved
cmd/kube-proxy/app/server_others.go Outdated Show resolved Hide resolved
cmd/kube-proxy/app/server_others.go Show resolved Hide resolved
cmd/kube-proxy/app/server_others_test.go Outdated Show resolved Hide resolved
@satyasm satyasm force-pushed the satyasm:kep-local-cidr branch from 5663e1a to 667b6b0 Mar 7, 2020
@satyasm

This comment has been minimized.

Copy link
Contributor Author

satyasm commented Mar 7, 2020

/retest

1 similar comment
@satyasm

This comment has been minimized.

Copy link
Contributor Author

satyasm commented Mar 7, 2020

/retest

@satyasm satyasm force-pushed the satyasm:kep-local-cidr branch from 667b6b0 to b9ea0d2 Mar 8, 2020
@satyasm

This comment has been minimized.

Copy link
Contributor Author

satyasm commented Mar 8, 2020

/retest

@dcbw

This comment has been minimized.

Copy link
Member

dcbw commented Mar 9, 2020

@satyasm #47262 is an earlier attempt at this, FWIW.

@satyasm satyasm force-pushed the satyasm:kep-local-cidr branch from b9ea0d2 to 35fb65c Mar 9, 2020
@satyasm satyasm force-pushed the satyasm:kep-local-cidr branch from 35fb65c to 091eb6c Mar 9, 2020
@satyasm satyasm force-pushed the satyasm:kep-local-cidr branch from 091eb6c to e053fdd Mar 9, 2020
@satyasm

This comment has been minimized.

Copy link
Contributor Author

satyasm commented Mar 9, 2020

/retest

1 similar comment
@satyasm

This comment has been minimized.

Copy link
Contributor Author

satyasm commented Mar 9, 2020

/retest

Copy link
Member

thockin left a comment

Are all other issues addressed? If so, unhold.

/lgtm
/approve
/hold

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: satyasm, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin thockin added this to the v1.18 milestone Mar 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 900143c into kubernetes:master Mar 9, 2020
16 of 17 checks passed
16 of 17 checks passed
tide Not mergeable. Must be in milestone v1.18.
Details
cla/linuxfoundation satyasm authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ga-only-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.