Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printers ignoring object average value #89142

Merged
merged 1 commit into from Mar 26, 2020
Merged

Fix printers ignoring object average value #89142

merged 1 commit into from Mar 26, 2020

Conversation

zhouya0
Copy link
Contributor

@zhouya0 zhouya0 commented Mar 16, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:
When creats an HPA with metrics type object, using kubectl get will not show current value and average value. This PR will fix this.

Which issue(s) this PR fixes:

Fixes #kubernetes/kubectl#839

Does this PR introduce a user-facing change?:

Fix printers ignoring object average value

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 16, 2020
@zhouya0
Copy link
Contributor Author

zhouya0 commented Mar 16, 2020

/test pull-kubernetes-e2e-kind-ipv6

@zhouya0 zhouya0 mentioned this pull request Mar 16, 2020
Closed
@zhouya0
Copy link
Contributor Author

zhouya0 commented Mar 16, 2020

/assign @apelisse

@zhouya0
Copy link
Contributor Author

zhouya0 commented Mar 16, 2020

/test pull-kubernetes-verify

@apelisse
Copy link
Member

apelisse commented Mar 16, 2020 •
edited

I don't know anything about this, can you please find a more suited reviewer? Thanks

@zhouya0
Copy link
Contributor Author

zhouya0 commented Mar 17, 2020

I don't know anything about this, can you please find a more suited reviewer? Thanks

Sure, and thanks!

@zhouya0
Copy link
Contributor Author

zhouya0 commented Mar 19, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 19, 2020
@zhouya0 zhouya0 force-pushed the fix_printers_ignoring_object_average_value branch from 9d01c50 to 6a051b9 Compare March 19, 2020 05:36
@zhouya0
Copy link
Contributor Author

zhouya0 commented Mar 19, 2020

/test pull-kubernetes-e2e-kind-ipv6

1 similar comment
@zhouya0
Copy link
Contributor Author

zhouya0 commented Mar 24, 2020

/test pull-kubernetes-e2e-kind-ipv6

@zhouya0
Copy link
Contributor Author

zhouya0 commented Mar 24, 2020

/sig api-machinery
/kind bug

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 24, 2020
@k8s-ci-robot
Copy link
Contributor

@zhouya0: The label(s) kind/ cannot be applied, because the repository doesn't have them

In response to this:

/sig api-machinery
/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 24, 2020
@zhouya0
Copy link
Contributor Author

zhouya0 commented Mar 26, 2020

/cc @liggitt Please review this, really thanks!

soltysh
soltysh approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, zhouya0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8aca6dc into kubernetes:master Mar 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 26, 2020
@arjunrn arjunrn mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bseenu bseenu bseenu left review comments

@soltysh soltysh soltysh approved these changes

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@soltysh soltysh

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zhouya0 @apelisse @k8s-ci-robot @soltysh @bseenu