WIP: Remove the "100 missed start times" CronJob limit

[vllry]

(This code was written as a patch, and needs some cleanup to directly solve the problem in k/k).

Removes the 100 missed schedule times limit from CronJobs.

Introduces a binary search approach with the schedule.Next() function in the existing 3rd party cron module. The binary search provides a much sharper upper bound on the timespan checked, and number of Next() calls. EG, a minutely CronJob that has been failing for a year requires checking only ~20 Next() calls (log2(60*24*365) + 1) in order to get the most recent missed schedule.

Co-Authored-By: Tom Wanielista tomwans@users.noreply.github.com
Co-Authored-By: Kevin Yang 16491459+yangkev@users.noreply.github.com

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Removes a well-known limitation, where CronJobs could only miss 100 consecutive start times before needing to be re-created.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Needs doc updates, TBD.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vllry
To complete the pull request process, please assign erictune
You can assign the PR to them by writing /assign @erictune in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/controller/cronjob/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vllry]

/uncc @soltysh
/uncc @smarterclayton

/test pull-kubernetes-conformance-kind-ga-only-parallel

[vllry]

/test pull-kubernetes-e2e-kind

[k8s-ci-robot]

@vllry: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-verify	d4dcc26	link	/test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[k8s-ci-robot]

@vllry: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alexey-gavrilov-flant]

/reopen

[k8s-ci-robot]

@alexey-gavrilov-flant: You can't reopen an issue/PR unless you authored it or you are a collaborator.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ltagliamonte-dd]

@vllry is there any reason why this PR didn't get attention?
Few people are "suffering" from:

Cannot determine if job needs to be started: too many missed start time (> 100). Set or decrease .spec.startingDeadlineSeconds or check clock skew

[soltysh]

There's a new cronjob controller being written see #93370

[2rs2ts]

@soltysh The new cronjob controller has the same problem, according to this comment #81557 (comment)

I think this PR might be redundant with that one, #81557, though.